Re: [PATCH 1/2] fix typo in SubmittingPatches

Randy Dunlap
2007-10-27T03:51:13Z

On Fri, 26 Oct 2007 15:51:44 +0900 Keiichi KII wrote:

> From: Keiichi Kii <k-keiichi@bx.jp.nec.com>
>
> Fix typo.
>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Andy Whitcroft <apw@shadowen.org>
> ---
> Index: trunk/Documentation/SubmittingPatches
> ===================================================================
> --- trunk.orig/Documentation/SubmittingPatches
> +++ trunk/Documentation/SubmittingPatches
> @@ -464,7 +464,7 @@ section Linus Computer Science 101.
> Nuff said. If your code deviates too much from this, it is likely
> to be rejected without further review, and without comment.
>
> -Once significant exception is when moving code from one file to
> +One significant exception is when moving code from one file to
> another in this case you should not modify the moved code at all in
> the same patch which moves it. This clearly delineates the act of
> moving the code and your changes. This greatly aids review of the

That first sentence is still broken. It should be more like this,
with either a ":" or ";" or " -- " between clauses:

One significant exception is when moving code from one file to
another -- in this case you should not modify the moved code at all in
the same patch which moves it.

---
~Randy