From: Tejun Heo <htejun@gmail.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: James.Bottomley@steeleye.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: Disk spindown on rmmod sd_mod
Date: Fri, 26 Oct 2007 19:25:42 +0900 [thread overview]
Message-ID: <4721C0A6.4000200@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710022050200.28124@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> I am using 2.6.23-rc9 with pata_sis. `modprobe -r sd_mod`, which I ran
> from initramfs, caused all my disks to spindown - sd even told me so.
>
> I recall there has been talk a while back about whether to spin down
> disks on shutdown or not, but I do not think it touched the removal of
> sd_mod, did it? So either way, can someone fill me in why the spindown
> is done?
The problem is that it's difficult to tell why a disk is going down from
sd_shutdown(), so it issues STOP unless system state is SYSTEM_RESTART.
Maybe we need to issue STOP only for SYSTEM_HALT, SYSTEM_POWER_OFF and
SYSTEM_SUSPEND_DISK.
Thanks.
--
tejun
prev parent reply other threads:[~2007-10-26 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 18:53 Disk spindown on rmmod sd_mod Jan Engelhardt
2007-10-26 10:25 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4721C0A6.4000200@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@steeleye.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox