Re: Regression: commit "ide: constify struct ide_port_info" causes breakage

Sergei Shtylyov
2007-10-26T16:42:18Z

Hello.

Linus Torvalds wrote:

>> We can just convert cariables declared as 'struct hpt_info' to const too --
>>they are read-only templates.

> Generally "__devinitdata" is better than "const", since it means that the
> data may be thrown away.

Agreed.

> So if you drop one over the other,

No, just add 'const' to already __devinitdata data to make gcc happy again.

> it's generally the "const" that should be dropped ;/

Well, this may break when/if we need to add __devinitdata that is actually
r/w -- not likely with this driver but still...

> Linus

WBR, Sergei