Re: [patch] raid6: generate raid6tables.c with proper style

H. Peter Anvin
2007-10-26T17:02:25Z

Ingo Molnar wrote:
> * Simon Holm Thøgersen <odie@cs.aau.dk> wrote:
>
>> fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:
>>> Subject: raid6: generate raid6tables.c with proper style
>>> From: Ingo Molnar <mingo@elte.hu>
>> [snip]
>>
>>> Index: linux/drivers/md/mktables.c
>>> ===================================================================
>>> --- linux.orig/drivers/md/mktables.c
>>> +++ linux/drivers/md/mktables.c
>>> @@ -69,7 +69,9 @@ int main(int argc, char *argv[])
>>> for ( j = 0 ; j < 256 ; j += 8 ) {
>>> printf("\t\t");
>>> for ( k = 0 ; k < 8 ; k++ ) {
>>> - printf("0x%02x, ", gfmul(i,j+k));
>>> + if (k)
>>> + printf(" ");
>>> + printf("0x%02x,", gfmul(i,j+k));
>> What happened with the coding style here?
>
> i adopted to the existing (broken) one. Yes, mktables.c could need a
> good cleanup too.
>

More so than the output, IMNSHO. I'll take care of it.

-hpa