* [PATCH] voyager: fix breakage caused by boot_params problem
@ 2007-10-26 17:30 James Bottomley
2007-10-26 17:59 ` H. Peter Anvin
2007-10-27 1:26 ` Randy Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: James Bottomley @ 2007-10-26 17:30 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton, H. Peter Anvin; +Cc: linux-kernel
There was a missed conversion in the voyager architecture setup file
which this corrects.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
---
James
diff --git a/include/asm-x86/mach-voyager/setup_arch.h b/include/asm-x86/mach-voyager/setup_arch.h
index 84d01ad..10debd2 100644
--- a/include/asm-x86/mach-voyager/setup_arch.h
+++ b/include/asm-x86/mach-voyager/setup_arch.h
@@ -1,5 +1,5 @@
#include <asm/voyager.h>
-#define VOYAGER_BIOS_INFO ((struct voyager_bios_info *)(PARAM+0x40))
+#define VOYAGER_BIOS_INFO ((struct voyager_bios_info *)(&boot_params.apm_bios_info))
/* Hook to call BIOS initialisation function */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] voyager: fix breakage caused by boot_params problem
2007-10-26 17:30 [PATCH] voyager: fix breakage caused by boot_params problem James Bottomley
@ 2007-10-26 17:59 ` H. Peter Anvin
2007-10-27 1:26 ` Randy Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2007-10-26 17:59 UTC (permalink / raw)
To: James Bottomley; +Cc: Linus Torvalds, Andrew Morton, linux-kernel
James Bottomley wrote:
> There was a missed conversion in the voyager architecture setup file
> which this corrects.
>
> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
>
> ---
>
> James
>
> diff --git a/include/asm-x86/mach-voyager/setup_arch.h b/include/asm-x86/mach-voyager/setup_arch.h
> index 84d01ad..10debd2 100644
> --- a/include/asm-x86/mach-voyager/setup_arch.h
> +++ b/include/asm-x86/mach-voyager/setup_arch.h
> @@ -1,5 +1,5 @@
> #include <asm/voyager.h>
> -#define VOYAGER_BIOS_INFO ((struct voyager_bios_info *)(PARAM+0x40))
> +#define VOYAGER_BIOS_INFO ((struct voyager_bios_info *)(&boot_params.apm_bios_info))
>
> /* Hook to call BIOS initialisation function */
>
Acked-by: H. Peter Anvin <hpa@zytor.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] voyager: fix breakage caused by boot_params problem
2007-10-26 17:30 [PATCH] voyager: fix breakage caused by boot_params problem James Bottomley
2007-10-26 17:59 ` H. Peter Anvin
@ 2007-10-27 1:26 ` Randy Dunlap
2007-10-27 13:38 ` James Bottomley
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2007-10-27 1:26 UTC (permalink / raw)
To: James Bottomley
Cc: Linus Torvalds, Andrew Morton, H. Peter Anvin, linux-kernel
On Fri, 26 Oct 2007 12:30:28 -0500 James Bottomley wrote:
> There was a missed conversion in the voyager architecture setup file
> which this corrects.
>
> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Oh.
http://lkml.org/lkml/2007/10/22/180
even cc-ed to you.
> ---
>
> James
>
> diff --git a/include/asm-x86/mach-voyager/setup_arch.h b/include/asm-x86/mach-voyager/setup_arch.h
> index 84d01ad..10debd2 100644
> --- a/include/asm-x86/mach-voyager/setup_arch.h
> +++ b/include/asm-x86/mach-voyager/setup_arch.h
> @@ -1,5 +1,5 @@
> #include <asm/voyager.h>
> -#define VOYAGER_BIOS_INFO ((struct voyager_bios_info *)(PARAM+0x40))
> +#define VOYAGER_BIOS_INFO ((struct voyager_bios_info *)(&boot_params.apm_bios_info))
>
> /* Hook to call BIOS initialisation function */
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] voyager: fix breakage caused by boot_params problem
2007-10-27 1:26 ` Randy Dunlap
@ 2007-10-27 13:38 ` James Bottomley
0 siblings, 0 replies; 4+ messages in thread
From: James Bottomley @ 2007-10-27 13:38 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linus Torvalds, Andrew Morton, H. Peter Anvin, linux-kernel
On Fri, 2007-10-26 at 18:26 -0700, Randy Dunlap wrote:
> On Fri, 26 Oct 2007 12:30:28 -0500 James Bottomley wrote:
>
> > There was a missed conversion in the voyager architecture setup file
> > which this corrects.
> >
> > Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
>
> Oh.
> http://lkml.org/lkml/2007/10/22/180
> even cc-ed to you.
Gosh, sorry about that.
I actually marked it to be added too. Unfortunately, my usual MO is to
get voyager working with the first -rc and then see what the other
updates were ... in this case, I duplicated what you'd already done.
James
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-27 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-26 17:30 [PATCH] voyager: fix breakage caused by boot_params problem James Bottomley
2007-10-26 17:59 ` H. Peter Anvin
2007-10-27 1:26 ` Randy Dunlap
2007-10-27 13:38 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox