From: Jeff Garzik <jeff@garzik.org>
To: Dirk Hohndel <hohndel@linux.intel.com>
Cc: Jiri Kosina <jikos@jikos.cz>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Date: Mon, 29 Oct 2007 05:35:04 -0400 [thread overview]
Message-ID: <4725A948.7030603@garzik.org> (raw)
In-Reply-To: <20071029084917.GA12968@bigserver.hohndel.org>
Dirk Hohndel wrote:
> [INPUT] hidinput_connect incorrectly ignored return value from input_register_device
>
> Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
>
> ---
> drivers/hid/hid-input.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index dd332f2..880161b 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1186,13 +1186,21 @@ int hidinput_connect(struct hid_device *hid)
> * UGCI) cram a lot of unrelated inputs into the
> * same interface. */
> hidinput->report = report;
> - input_register_device(hidinput->input);
> + if (input_register_device(hidinput->input)) {
> + input_free_device(hidinput->input);
> + kfree(hidinput);
> + return -1;
> + }
> hidinput = NULL;
> }
> }
>
> if (hidinput)
> - input_register_device(hidinput->input);
> + if (input_register_device(hidinput->input)) {
> + input_free_device(hidinput->input);
> + kfree(hidinput);
> + return -1;
ACK, thanks for revising
next prev parent reply other threads:[~2007-10-29 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 6:51 [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device Dirk Hohndel
2007-10-29 7:53 ` Jeff Garzik
2007-10-29 8:49 ` Dirk Hohndel
2007-10-29 9:35 ` Jeff Garzik [this message]
2007-10-29 10:14 ` Jiri Kosina
2007-10-29 12:54 ` Dmitry Torokhov
2007-10-29 12:57 ` Jiri Kosina
2007-10-29 14:49 ` Jeff Garzik
2007-10-29 15:20 ` Dirk Hohndel
2007-10-29 15:33 ` Dmitry Torokhov
2007-10-29 15:38 ` Hohndel, Dirk
2007-10-29 17:11 ` Dmitry Torokhov
2007-10-29 17:28 ` Jiri Kosina
2007-10-29 22:50 ` Dirk Hohndel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4725A948.7030603@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=hohndel@linux.intel.com \
--cc=jikos@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox