* [2.6 patch] scsi/seagate.c: remove dead code
@ 2007-10-28 15:51 Adrian Bunk
2007-10-28 15:53 ` Matthew Wilcox
2007-10-29 9:44 ` Boaz Harrosh
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2007-10-28 15:51 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, linux-kernel
This patch removes obviously dead code.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/scsi/seagate.c | 2 --
1 file changed, 2 deletions(-)
c0807bbefb65ef679b7d2ec13d14c35f2e927404
diff --git a/drivers/scsi/seagate.c b/drivers/scsi/seagate.c
index b113244..2d31ed4 100644
--- a/drivers/scsi/seagate.c
+++ b/drivers/scsi/seagate.c
@@ -1437,17 +1437,15 @@ connect_loop:
break;
#ifdef LINKED
case LINKED_WRONG:
WRITE_DATA (ABORT);
linked_connected = 0;
reselect = CAN_RECONNECT;
goto connect_loop;
- DPRINTK (PHASE_MSGOUT | DEBUG_LINKED, "scsi%d : sent ABORT message to cancel incorrect I_T_L nexus.\n", hostno);
#endif /* LINKED */
- DPRINTK (DEBUG_LINKED, "correct\n");
default:
WRITE_DATA (NOP);
printk("scsi%d : target %d requested MSGOUT, sent NOP message.\n", hostno, target);
}
break;
case REQ_MSGIN:
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [2.6 patch] scsi/seagate.c: remove dead code
2007-10-28 15:51 [2.6 patch] scsi/seagate.c: remove dead code Adrian Bunk
@ 2007-10-28 15:53 ` Matthew Wilcox
2007-10-29 9:44 ` Boaz Harrosh
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2007-10-28 15:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James.Bottomley, linux-scsi, linux-kernel
On Sun, Oct 28, 2007 at 04:51:42PM +0100, Adrian Bunk wrote:
> This patch removes obviously dead code.
> case LINKED_WRONG:
> WRITE_DATA (ABORT);
> linked_connected = 0;
> reselect = CAN_RECONNECT;
> goto connect_loop;
> - DPRINTK (PHASE_MSGOUT | DEBUG_LINKED, "scsi%d : sent ABORT message to cancel incorrect I_T_L nexus.\n", hostno);
> #endif /* LINKED */
> - DPRINTK (DEBUG_LINKED, "correct\n");
> default:
Surely the 'goto' should just be moved two lines down?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] scsi/seagate.c: remove dead code
2007-10-28 15:51 [2.6 patch] scsi/seagate.c: remove dead code Adrian Bunk
2007-10-28 15:53 ` Matthew Wilcox
@ 2007-10-29 9:44 ` Boaz Harrosh
1 sibling, 0 replies; 3+ messages in thread
From: Boaz Harrosh @ 2007-10-29 9:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: James.Bottomley, linux-scsi, linux-kernel
On Sun, Oct 28 2007 at 17:51 +0200, Adrian Bunk <bunk@kernel.org> wrote:
> This patch removes obviously dead code.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> drivers/scsi/seagate.c | 2 --
> 1 file changed, 2 deletions(-)
>
Actually I have sent a patch to completely remove this driver.
http://www.spinics.net/lists/linux-scsi/msg20308.html
Does any one objects?
Boaz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-29 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-28 15:51 [2.6 patch] scsi/seagate.c: remove dead code Adrian Bunk
2007-10-28 15:53 ` Matthew Wilcox
2007-10-29 9:44 ` Boaz Harrosh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox