public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keiichi KII <k-keiichi@bx.jp.nec.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: gregkh@suse.de, Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH 1/2] fix typo in SubmittingPatches
Date: Mon, 29 Oct 2007 19:51:38 +0900	[thread overview]
Message-ID: <4725BB3A.9020208@bx.jp.nec.com> (raw)
In-Reply-To: <47218E80.50700@bx.jp.nec.com>

From: Keiichi Kii <k-keiichi@bx.jp.nec.com>

Greg, could you replace old patch with new one?

Fix typo and insert " -- " between clauses.

Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
Cc: Andy Whitcroft <apw@shadowen.org>
---
Index: trunk/Documentation/SubmittingPatches
===================================================================
--- trunk.orig/Documentation/SubmittingPatches
+++ trunk/Documentation/SubmittingPatches
@@ -464,8 +464,8 @@ section Linus Computer Science 101.
 Nuff said.  If your code deviates too much from this, it is likely
 to be rejected without further review, and without comment.
 
-Once significant exception is when moving code from one file to
-another in this case you should not modify the moved code at all in
+One significant exception is when moving code from one file to
+another -- in this case you should not modify the moved code at all in
 the same patch which moves it.  This clearly delineates the act of
 moving the code and your changes.  This greatly aids review of the
 actual differences and allows tools to better track the history of


-- 
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: k-keiichi@bx.jp.nec.com

  parent reply	other threads:[~2007-10-29 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26  6:48 [PATCH 0/2] Japanese translation of Documentation/SubmittingPatches Keiichi KII
2007-10-26  6:51 ` [PATCH 1/2] fix typo in SubmittingPatches Keiichi KII
2007-10-27  3:50   ` Randy Dunlap
2007-10-29 10:50     ` Keiichi KII
2007-10-29 10:51   ` Keiichi KII [this message]
2007-10-26  6:55 ` [PATCH 2/2] add SubmittingPatches to Documentation/ja_JP Keiichi KII
2007-10-26  7:12   ` YOSHIFUJI Hideaki / 吉藤英明
2007-10-26 11:48     ` Keiichi KII

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4725BB3A.9020208@bx.jp.nec.com \
    --to=k-keiichi@bx.jp.nec.com \
    --cc=apw@shadowen.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox