* [PATCH] pciserial_resume_one ignored return value of pci_enable_device
@ 2007-10-29 13:28 Dirk Hohndel
2007-10-29 13:50 ` Alan Cox
2007-10-29 14:46 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Dirk Hohndel @ 2007-10-29 13:28 UTC (permalink / raw)
To: Greg KH, linux-kernel
[PATCH] pciserial_resume_one ignored return value of pci_enable_device
Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
---
drivers/serial/8250_pci.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
index 0e35756..ceb03c9 100644
--- a/drivers/serial/8250_pci.c
+++ b/drivers/serial/8250_pci.c
@@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)
static int pciserial_resume_one(struct pci_dev *dev)
{
+ int err;
struct serial_private *priv = pci_get_drvdata(dev);
pci_set_power_state(dev, PCI_D0);
@@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
/*
* The device may have been disabled. Re-enable it.
*/
- pci_enable_device(dev);
+ err = pci_enable_device(dev);
+ if (err)
+ return err;
pciserial_resume_ports(priv);
}
--
gitgui.0.8.4.g8d863
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pciserial_resume_one ignored return value of pci_enable_device
2007-10-29 13:28 [PATCH] pciserial_resume_one ignored return value of pci_enable_device Dirk Hohndel
@ 2007-10-29 13:50 ` Alan Cox
2007-10-29 14:46 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-10-29 13:50 UTC (permalink / raw)
To: Dirk Hohndel; +Cc: Greg KH, linux-kernel
On Mon, 29 Oct 2007 06:28:17 -0700
Dirk Hohndel <hohndel@linux.intel.com> wrote:
> [PATCH] pciserial_resume_one ignored return value of pci_enable_device
>
> Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
Acked-by: Alan Cox <alan@redhat.com>
Not sure its worth the hassle but I guess someone could pull a hotplug
PCI serial card and then resume.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pciserial_resume_one ignored return value of pci_enable_device
2007-10-29 13:28 [PATCH] pciserial_resume_one ignored return value of pci_enable_device Dirk Hohndel
2007-10-29 13:50 ` Alan Cox
@ 2007-10-29 14:46 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2007-10-29 14:46 UTC (permalink / raw)
To: Dirk Hohndel; +Cc: Greg KH, linux-kernel
Dirk Hohndel wrote:
> [PATCH] pciserial_resume_one ignored return value of pci_enable_device
>
> Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
>
> ---
> drivers/serial/8250_pci.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
> index 0e35756..ceb03c9 100644
> --- a/drivers/serial/8250_pci.c
> +++ b/drivers/serial/8250_pci.c
> @@ -1986,6 +1986,7 @@ static int pciserial_suspend_one(struct pci_dev *dev, pm_message_t state)
>
> static int pciserial_resume_one(struct pci_dev *dev)
> {
> + int err;
> struct serial_private *priv = pci_get_drvdata(dev);
>
> pci_set_power_state(dev, PCI_D0);
> @@ -1995,7 +1996,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
> /*
> * The device may have been disabled. Re-enable it.
> */
> - pci_enable_device(dev);
> + err = pci_enable_device(dev);
> + if (err)
> + return err;
ACK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-29 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-29 13:28 [PATCH] pciserial_resume_one ignored return value of pci_enable_device Dirk Hohndel
2007-10-29 13:50 ` Alan Cox
2007-10-29 14:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox