From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755578AbXJ2Tpx (ORCPT ); Mon, 29 Oct 2007 15:45:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754652AbXJ2Tlj (ORCPT ); Mon, 29 Oct 2007 15:41:39 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:44359 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbXJ2Tli (ORCPT ); Mon, 29 Oct 2007 15:41:38 -0400 Message-ID: <4726376E.3080608@garzik.org> Date: Mon, 29 Oct 2007 15:41:34 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.5 (X11/20070727) MIME-Version: 1.0 To: Jan Engelhardt CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API References: <47dcd058deaaf90802c720df243f5c8b26ed9de3.1193686354.git.jeff@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jan Engelhardt wrote: > On Oct 29 2007 15:33, Jeff Garzik wrote: >> +#if 0 /* info available elsewhere, but this is kept for reference */ > > It is available in the git history, yes, is it still needed for reference? it's there to see if anyone complains at its removal :) >> +static short ibmlana_adapter_ids[] __initdata = { >> + IBM_LANA_ID, >> + 0x0000 >> +}; >> + >> +static char *ibmlana_adapter_names[] __initdata = { >> + "IBM LAN Adapter/A", >> + NULL >> +}; > > Can this be const? Not with the initdata marker, no. Jeff