Re: [PATCH] raise tsc clocksource rating

Ingo Molnar
2007-10-29T23:02:46Z

* Zachary Amsden <zach@vmware.com> wrote:

> On Mon, 2007-10-29 at 23:48 +0100, Ingo Molnar wrote:
> > * Zachary Amsden <zach@vmware.com> wrote:
>
> > if it's inaccurate why are you exposing it to the guest then? Native
> > only uses the TSC if it's safe and accurate to do so.
>
> Not every guest support paravirt, but for correctness, all guests
> require TSC, which must be exposed all the way up to userspace, no
> matter what the efficiency or accuracy may be.

but if there's a perfect TSC available (there is such hardware) then the
TSC _is_ the best clocksource. Paravirt now turns it off unconditionally
in essence.

anyway, that's at most an optimization issue. No strong feelings here,
and we can certainly delay this patch until this gets all sorted out.

Ingo