public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: apw@shadowen.org, linux-kernel@vger.kernel.org
Subject: checkpatch bug: space between left parenthesis and asterisk
Date: Tue, 30 Oct 2007 14:27:13 -0500	[thread overview]
Message-ID: <47278591.90305@freescale.com> (raw)

I'm running checkpatch.pl (dated 10/17), and it complains about this line:

crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));

the message I get is:

ERROR: need space before that '*' (ctx:BxW)
#721: FILE: arch/powerpc/sysdev/qe_lib/qe.c:527:
+       crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
                             ^

so I add a space, and now I get this:

ERROR: no space after that open parenthesis '('
#721: FILE: arch/powerpc/sysdev/qe_lib/qe.c:527:
+       crc = __be32_to_cpu( * ((__be32 *) ((void *) firmware + calc_size)));


             reply	other threads:[~2007-10-30 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 19:27 Timur Tabi [this message]
2007-10-30 19:54 ` checkpatch bug: space between left parenthesis and asterisk Zach Brown
2007-10-30 20:02   ` Timur Tabi
2007-10-30 21:46 ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47278591.90305@freescale.com \
    --to=timur@freescale.com \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox