From: "H. Peter Anvin" <hpa@zytor.com>
To: "Kirill A. Shutemov" <k.shutemov@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] Unexport asm/user.h and linux/user.h
Date: Wed, 31 Oct 2007 14:06:11 -0700 [thread overview]
Message-ID: <4728EE43.2080206@zytor.com> (raw)
In-Reply-To: <1193845777-2007-3-git-send-email-k.shutemov@gmail.com>
Kirill A. Shutemov wrote:
> Do not export asm/user.h and linux/user.h during make headers_install.
>
> Signed-off-by: Kirill A. Shutemov <k.shutemov@gmail.com>
> Reviewed-By: David Woodhouse <dwmw2@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
The version that is in there is currently broken from a user-space
perspective (gdb expects u_ar0 to be struct user_regs_struct *, which it
isn't for a bunch of the architectures defined); it *could* be argued
the right thing is to fix it up since it *does* export an ABI
-- specifically, the format of a.out core dumps -- but it is probably
easier to just axe it; userspace has had to deal with this issue on its
own for a long time already.
As such,
Acked-by: H. Peter Anvin <hpa@zytor.com>
next prev parent reply other threads:[~2007-10-31 21:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 15:49 [PATCH] Unexport asm/page.h Kirill A. Shutemov
2007-10-31 15:49 ` [PATCH] Unexport asm/elf.h Kirill A. Shutemov
2007-10-31 15:49 ` [PATCH] Unexport asm/user.h and linux/user.h Kirill A. Shutemov
2007-10-31 21:06 ` H. Peter Anvin [this message]
2007-10-31 21:10 ` [PATCH] Sanitize the type of struct user.u_ar0 H. Peter Anvin
2007-10-31 15:49 ` [PATCH] Cleanup asm/{elf,page,user}.h: #ifdef __KERNEL__ is no longer needed Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 16:35 [PATCH] Unexport asm/page.h Kirill A. Shutemov
2007-10-24 16:36 ` [PATCH] Unexport asm/elf.h Kirill A. Shutemov
2007-10-24 16:36 ` [PATCH] Unexport asm/user.h and linux/user.h Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4728EE43.2080206@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=k.shutemov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox