Re: [PATCH/RFC] x86: unify Kconfig files

Sam Ravnborg
2007-11-01T05:23:45Z

On Wed, Oct 31, 2007 at 09:08:03PM -0700, Jeremy Fitzhardinge wrote:
> Sam Ravnborg wrote:
> > It has been requested that we should let x86 behave like
> > other architectures so we at config time decide for 32 or 64 bit.
> > The challenge here is to mere the Kconfig files and I have done
> > an attempt to do so.
> >
> > +source "mm/Kconfig"
> >
> > -config X86_VISWS_APIC
> > +config HIGHPTE
> > + bool "Allocate 3rd-level pagetables from highmem"
> > + depends on X86_32 && HIGHMEM4G || HIGHMEM64G
> >
>
> Some parens: X86_32 && (HIGHMEM4G || HIGHMEM64G)?

Yes - thanks.

This particular X86_32 dependency is for documentation only since
HIGHMEM4G and HIGHMEM64G is a X86_32 thing only.
But depite this is should be correct.
I will audit the other dependencies for the same bug.

Sam