public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Logan <joshtlogan@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ciaran McCreesh <ciaran.mccreesh@blueyonder.co.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: Abit F-190HD Onboard rlt8169 Ethernet Controller
Date: Thu, 01 Nov 2007 09:17:58 -0700	[thread overview]
Message-ID: <4729FC36.3040000@gmail.com> (raw)
In-Reply-To: <20071029083333.18a4dab7@the-village.bc.nu>

Alan Cox wrote:
>> It is not recognised by 2.6.24-rc1. I'm guessing it's because the
>> vendor ID is 0001 rather than something sensible. I patched the kernel
>> as follows:
> 
> A vendor ID of 1 is very very very broken. Do all boards have this or do
> you have a faulty box (perhaps a misprogrammed EEPROM somewhere)
> 
>> --- drivers/net/r8169.c.orig	2007-10-29 05:37:02.000000000 +0000
>> +++ drivers/net/r8169.c	2007-10-29 05:54:30.000000000 +0000
>> @@ -165,6 +165,7 @@
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8136), 0, 0, RTL_CFG_2 },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8167), 0, 0, RTL_CFG_0 },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8168), 0, 0, RTL_CFG_1 },
>> +	{ PCI_DEVICE(PCI_ANY_ID,		0x8168), 0, 0, RTL_CFG_2 },
> 
> That will match any device 0x8168 not just a realtek one. I'd use 0x0001,
> 0x8168 for the match. However I'd seriously consider checking another
> board as I suspect you simply have a return candidate.
> 

I have had this board for a few months as well and I have needed to 
patch the driver to use 0x0001 as well.

							Later, JOSH

  parent reply	other threads:[~2007-11-01 16:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29  6:15 Abit F-190HD Onboard rlt8169 Ethernet Controller Ciaran McCreesh
2007-10-29  8:33 ` Alan Cox
2007-10-29  8:42   ` Jeff Garzik
2007-10-29 12:00     ` Francois Romieu
2007-10-30  0:27       ` Ciaran McCreesh
2007-10-30 22:59         ` Francois Romieu
2007-10-30 23:49           ` Ciaran McCreesh
2007-10-29  8:49   ` Ciaran McCreesh
2007-11-01 16:17   ` Josh Logan [this message]
2007-11-01 21:53     ` Francois Romieu
2007-11-02  0:05       ` Ciaran McCreesh
2007-11-07  5:21       ` Josh Logan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4729FC36.3040000@gmail.com \
    --to=joshtlogan@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ciaran.mccreesh@blueyonder.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox