Re: [PATCH] x86: show cpuinfo only for online CPUs

[Glauber de Oliveira Costa <gcosta@redhat.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Herrmann escreveu:
> This patch applies on current Linus' git with Glauber's recent cpuinfo fix
> (http://marc.info/?l=linux-kernel&m=119392088227245) applied.
> 
> 
> Regards,
> 
> Andreas
> 

Andreas,

did you test it in a kernel without SMP compiled in ?

I'm a little afraid about what can happen here:

- --- a/arch/x86/kernel/setup_64.c
+++ b/arch/x86/kernel/setup_64.c
@@ -998,7 +998,7 @@ void __cpuinit print_cpu_info(struct cpuinfo_x86 *c)
 static int show_cpuinfo(struct seq_file *m, void *v)
 {
 	struct cpuinfo_x86 *c = v;
- -	int cpu = 0;
+	int cpu = c->cpu_index;

The attribuition of cpu_index only happens in a code that seems to be
called for all cpus but the boot one.

So it could even work, but as accident. Unless I'm wrong about it, I'd
prefer to see an explicit attribution of cpu_index = 0 somewhere for the
boot cpu.

Other than that, good catch! I didn't notice it, because all my present
cpus were online in my box
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Remi - http://enigmail.mozdev.org

iD8DBQFHKgj5jYI8LaFUWXMRAsU1AJ4ixYO42zHGK3Kx5SXH+cdly/rZ6wCfX6Kh
q2OCPt2qTniPmMNz+MzXc60=
=mYoV
-----END PGP SIGNATURE-----