From: "H. Peter Anvin" <hpa@zytor.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH] fix i486 boot failure due to stale %ds
Date: Sun, 04 Nov 2007 11:00:38 -0800 [thread overview]
Message-ID: <472E16D6.4080706@zytor.com> (raw)
In-Reply-To: <472E0F8E.1010609@zytor.com>
[-- Attachment #1: Type: text/plain, Size: 55 bytes --]
Urk, -ENOTAWAKEYET. Try *THIS* patch, please.
-hpa
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 1222 bytes --]
diff --git a/arch/x86/boot/pmjump.S b/arch/x86/boot/pmjump.S
index 2e55923..17e6dec 100644
--- a/arch/x86/boot/pmjump.S
+++ b/arch/x86/boot/pmjump.S
@@ -28,27 +28,37 @@
* void protected_mode_jump(u32 entrypoint, u32 bootparams);
*/
protected_mode_jump:
- xorl %ebx, %ebx # Flag to indicate this is a boot
movl %edx, %esi # Pointer to boot_params table
- movl %eax, 2f # Patch ljmpl instruction
+
+ xorl %edx, %edx
+ movw %cs, %dx
+ shll $4, %edx # Patch ljmpl instruction
+ addl %edx, 2f
jmp 1f # Short jump to flush instruction q.
1:
movw $__BOOT_DS, %cx
+ xorl %ebx, %ebx # Per protocol
+ xorl %ebp, %ebp # Per protocol
+ xorl %edi, %edi # Per protocol
movl %cr0, %edx
orb $1, %dl # Protected mode (PE) bit
movl %edx, %cr0
+
+ .byte 0x66, 0xea # ljmpl opcode
+2: .long 3f # Offset
+ .word __BOOT_CS # Segment
- movw %cx, %ds
- movw %cx, %es
- movw %cx, %fs
- movw %cx, %gs
- movw %cx, %ss
+ .code32
+3:
+ movl %ecx, %ds
+ movl %ecx, %es
+ movl %ecx, %fs
+ movl %ecx, %gs
+ movl %ecx, %ss
# Jump to the 32-bit entrypoint
- .byte 0x66, 0xea # ljmpl opcode
-2: .long 0 # offset
- .word __BOOT_CS # segment
-
+ jmpl *%eax
+
.size protected_mode_jump, .-protected_mode_jump
next prev parent reply other threads:[~2007-11-04 19:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 16:44 [PATCH] fix i486 boot failure due to stale %ds Mikael Pettersson
2007-11-04 18:29 ` H. Peter Anvin
2007-11-04 19:00 ` H. Peter Anvin [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-04 19:38 Mikael Pettersson
2007-11-04 19:41 ` H. Peter Anvin
2007-11-04 21:58 Mikael Pettersson
2007-11-04 22:20 ` H. Peter Anvin
2007-11-04 23:05 ` Andi Kleen
2007-11-04 23:07 ` Jeremy Fitzhardinge
2007-11-04 23:12 ` H. Peter Anvin
2007-11-04 23:50 ` H. Peter Anvin
2007-11-05 0:15 ` Linus Torvalds
2007-11-05 0:23 ` Linus Torvalds
2007-11-04 23:51 ` H. Peter Anvin
2007-11-05 1:18 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472E16D6.4080706@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox