Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

[Jiri Slaby <jirislaby@gmail.com>]

Andrew Morton napsal(a):
> On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby <jirislaby@gmail.com> wrote:
> 
>> stk11xx, add a new webcam driver
>>
>> Adds support for stk1125, stk1135 and stkdcnew webcam built-in some
>> notebooks.
> 
> Seem that something in git-dvb (or mainline) broke this driver:
> 
> drivers/media/video/stk11xx-core.c: In function 'show_contrast':
> drivers/media/video/stk11xx-core.c:707: warning: initialization from incompatible pointer type
> drivers/media/video/stk11xx-core.c: In function 'show_whitebalance':
> drivers/media/video/stk11xx-core.c:714: warning: initialization from incompatible pointer type
> drivers/media/video/stk11xx-core.c: In function 'stk11xx_create_sysfs_file':
> drivers/media/video/stk11xx-core.c:727: warning: passing argument 1 of 'class_device_create_file' from incompatible pointer type
> drivers/media/video/stk11xx-core.c: In function 'stk11xx_usb_disconnect':
> drivers/media/video/stk11xx-core.c:851: warning: passing argument 1 of 'class_device_remove_file' from incompatible pointer type
> drivers/media/video/stk11xx-core.c:853: warning: passing argument 1 of 'class_device_remove_file' from incompatible pointer type
> 
> Also, please ask the v4l/dvb guys to look at this driver - there's not a lot
> of point in sending it just to me.

Dvb fellows reviewed it some time ago, but the problem is, that it converts
one color space to another in kernelspace. We are developping an userspace
library for drivers such this one, but it takes longer than I expect. Lets
have it dropped, after the library will be done I'll merge it through v4l tree.

thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz