From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6C56126C13; Fri, 11 Apr 2025 15:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744386458; cv=none; b=lR8ZezvdUlp6/oyvH0o449VO95Hge47HLEfuxL8ySUosXzqgFJrsZSINEk0OnpdDenNljXJAgeLQ7soN2jbxSFJrSaBG+fbjJdTrNLuWgbOvJjAUJWg257d3UJ3auEL6XjwiSOL1/VkO8rlwV3xyZQe3Slsrrlhdvwr4f9frKGE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744386458; c=relaxed/simple; bh=po4BvKzJF2xBksLFY2NnG7GejpaqqPlM+UT7tazBV6o=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qVxEshLNKWPEONSmJfytgIVkFEnNDcgfHToVkt5JntRm9t9x4Zr4vfELRvGnGe4eNX0X6FEDI1nQoyF2SR0t7HmygUNUwC0Ri0DC+X0VBUgCj4RmcgXLhoQ1lA/AYGT68uWvG1CLomZTlsn4lMG8WnVh9FL+dGW1NZYZmVpGKy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=N6S1vzww; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="N6S1vzww" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1744386453; bh=po4BvKzJF2xBksLFY2NnG7GejpaqqPlM+UT7tazBV6o=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=N6S1vzwwBb+zQZm0uasxR1zixpz9L1eCoruKAMEV3yigigQ3ihzp6BqKrn+UeSatM z4b6xU937yiZXvSwEUhb/dMYIDPcQmhI5g1lA30zAq8B1wEgeMkK5O4VlP61LRSdTS ILTbYdSuL4pl1p+rsNPvq0QZqn9/Ad74P2KTehDjYXktI0XzkNOnWfSOyFAJI8Ock2 ULOPpuVKCURN4drEhjkO37o4m6UkjB08E/UyIJOBoKzVK3VWiwc0ZOWw8SJzN3VwAs hmaqRrxmlNgDTXkO4sD4pniKTFcVe7VIkQMIK50ryhkK8qjbks0a+wPeb/9ktl2vUu y5DPTY6RuFvkg== Received: from [IPv6:2606:6d00:11:e976::5ac] (unknown [IPv6:2606:6d00:11:e976::5ac]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id 69DE717E0FD9; Fri, 11 Apr 2025 17:47:32 +0200 (CEST) Message-ID: <47312bcc8352bf190a59de448d9fd31f04ef954d.camel@collabora.com> Subject: Re: [RESEND PATCH v1 0/7] Performance improvement of decoder From: Nicolas Dufresne To: "jackson.lee" , "mchehab@kernel.org" , "hverkuil-cisco@xs4all.nl" , "sebastian.fricke@collabora.com" , "bob.beckett@collabora.com" , "dafna.hirschfeld@collabora.com" Cc: "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lafley.kim" , "b-brnich@ti.com" , "hverkuil@xs4all.nl" , Nas Chung Date: Fri, 11 Apr 2025 11:47:31 -0400 In-Reply-To: References: <20250410034002.88-1-jackson.lee@chipsnmedia.com> Organization: Collabora Canada Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.56.0 (3.56.0-1.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, Le vendredi 11 avril 2025 à 00:49 +0000, jackson.lee a écrit : > Hi Nicolas > > There was warning message of patch work. > Hash value of "Improve performance of decoder" in the patch series > were used for FIXS tag, I removed the FIXS tags in the commit > message. I'd prefer if you simply comment back that this needs to be removed before merging. If you get enough comment for a new version, you can do it, if its the only thing preventing the merge, I will fix it. Resends are mostly used when a patches have had no comment, no feedback for a long period of time. When the patches have been forgotten, and are not expected to hold any edits. regards, Nicolas > > thanks > > > > > -----Original Message----- > > From: Nicolas Dufresne > > Sent: Thursday, April 10, 2025 9:39 PM > > To: jackson.lee ; mchehab@kernel.org; > > hverkuil-cisco@xs4all.nl; sebastian.fricke@collabora.com; > > bob.beckett@collabora.com; dafna.hirschfeld@collabora.com > > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > > lafley.kim > > ; b-brnich@ti.com; hverkuil@xs4all.nl; > > Nas > > Chung > > Subject: Re: [RESEND PATCH v1 0/7] Performance improvement of > > decoder > > > > Hi, > > > > Le jeudi 10 avril 2025 à 12:39 +0900, Jackson.lee a écrit : > > > From: Jackson Lee > > > > > > v4l2-compliance results: > > > ======================== > > > > What there reason for a resend within 3h ? > > > > Nicolas > > > > > > > > v4l2-compliance 1.28.1-5233, 64 bits, 64-bit time_t > > > > > > Buffer ioctls: > > >                 warn: v4l2-test-buffers.cpp(693): > > > VIDIOC_CREATE_BUFS > > > not supported > > >                 warn: v4l2-test-buffers.cpp(693): > > > VIDIOC_CREATE_BUFS > > > not supported > > >         test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > > >         test CREATE_BUFS maximum buffers: OK > > >         test VIDIOC_EXPBUF: OK > > >         test Requests: OK (Not Supported) > > > > > > Total for wave5-dec device /dev/video0: 46, Succeeded: 46, > > > Failed: 0, > > > Warnings: 2 > > > Total for wave5-enc device /dev/video1: 46, Succeeded: 46, > > > Failed: 0, > > > Warnings: 0 > > > > > > Fluster test results: > > > ===================== > > > > > > Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265- > > > V4L2- > > > Gst1.0 > > > Using 3 parallel job(s) > > > Ran 133/147 tests successfully               in 41.629 secs > > > > > > (1 test fails because of not supporting to parse multi frames, 1 > > > test > > > fails because of a missing frame and slight corruption, > > >  2 tests fail because of sizes which are incompatible with the > > > IP, 11 > > > tests fail because of unsupported 10 bit format) > > > > > > > > > Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2- > > > Gst1.0 > > > Using 3 parallel job(s) > > > Ran 78/135 tests successfully               in 44.578 secs > > > > > > (57 fail because the hardware is unable to decode  MBAFF / FMO / > > > Field > > > / Extended profile streams.) > > > > > > Seek test > > > ===================== > > > 1. gst-play-1.0 seek.264 > > > 2. this will use waylandsink since gst-play-1.0 uses playbin. > > >    if you don't want to hook up display, > > >    you can run gst-play-1.0 seek.264 --videosink=fakevideosink > > > instead > > > 3. Let pipeline run for 2-3 seconds 4. press SPACE key to pause > > > 5. > > > press 0 to reset press SPACE to start again > > > > > > gst-play-1.0 seek.264 --videosink=fakevideosink Press 'k' to see > > > a > > > list of keyboard shortcuts. > > > Now playing /root/seek.264 > > > Redistribute latency... > > > Redistribute latency... > > > Redistribute latency... > > > Redistribute latency... > > > Redistribute latency...aused > > > 0:00:09.9 / 0:00:09.7 > > > Reached end of play list. > > > > > > Sequence Change test > > > ===================== > > > gst-launch-1.0 filesrc > > > location=./switch_1080p_720p_240frames.h264 ! > > > h264parse ! v4l2h264dec ! filesink location=./h264_output_420.yuv > > > Setting pipeline to PAUSED ... > > > Pipeline is PREROLLING ... > > > Redistribute latency... > > > Redistribute latency... > > > Pipeline is PREROLLED ... > > > Setting pipeline to PLAYING ... > > > Redistribute latency... > > > New clock: GstSystemClock > > > Got EOS from element "pipeline0". > > > Execution ended after 0:00:05.772414400 Setting pipeline to NULL > > > ... > > > Freeing pipeline ... > > > > > > Change since v0: > > > =================== > > > * For [PATCH v1 2/7] media: chips-media: wave5: Improve > > > performance of > > > decoder > > >  - separates the previous patch to a few patches > > > > > > * For [PATCH v1 3/7] media: chips-media: wave5: Fix not to be > > > closed > > >  - separated from the previous patch of performance improvement > > > of > > >    decoder > > > > > > * For [PATCH v1 4/7] media: chips-media: wave5: Use spinlock > > > whenever > > > state is changed > > >  - separated from the previous patch of performance improvement > > > of > > >    decoder > > > > > > * For [PATCH v1 5/7] media: chips-media: wave5: Fix not to free > > > resources normally when > > >     instance was destroyed > > >  - separated from the previous patch of performance improvement > > > of > > >    decoder > > > > > > * For [PATCH v1 7/7] media: chips-media: wave5: Fix SError of > > > kernel > > > panic when closed > > >  - separated from the previous patch of performance improvement > > > of > > >    decoder > > > > > > Jackson Lee (7): > > >   media: chips-media: wave5: Fix Null reference while testing > > > fluster > > >   media: chips-media: wave5: Improve performance of decoder > > >   media: chips-media: wave5: Fix not to be closed > > >   media: chips-media: wave5: Use spinlock whenever state is > > > changed > > >   media: chips-media: wave5: Fix not to free resources normally > > > when > > >     instance was destroyed > > >   media: chips-media: wave5: Reduce high CPU load > > >   media: chips-media: wave5: Fix SError of kernel panic when > > > closed > > > > > >  .../platform/chips-media/wave5/wave5-helper.c |  10 +- > > >  .../chips-media/wave5/wave5-vpu-dec.c         | 116 +++++++++++- > > > ---- > > > -- > > >  .../chips-media/wave5/wave5-vpu-enc.c         |   8 +- > > >  .../platform/chips-media/wave5/wave5-vpu.c    |  70 +++++++++-- > > >  .../platform/chips-media/wave5/wave5-vpuapi.c |  36 +++--- > > >  .../platform/chips-media/wave5/wave5-vpuapi.h |  10 ++ > > >  .../chips-media/wave5/wave5-vpuconfig.h       |   1 + > > >  7 files changed, 179 insertions(+), 72 deletions(-) > > > > -- > > Nicolas Dufresne > > Principal Engineer at Collabora -- Nicolas Dufresne Principal Engineer at Collabora