From: Mark Lord <lkml@rtr.ca>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Garzik <jgarzik@pobox.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] r8169 fix regression on ASUS motherboards
Date: Wed, 07 Nov 2007 17:21:29 -0500 [thread overview]
Message-ID: <47323A69.5050206@rtr.ca> (raw)
In-Reply-To: <20071107220455.GA15367@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Mark Lord <lkml@rtr.ca> :
>> Fix r8169 regression on ASUS motherboards.
>>
>> The r8169 ethernet driver worked fine in 2.6.23, but fails
>> in 2.6.24-rc* for the onboard ethernet of ASUS P5B series motherboards.
>> This patch fixes it again.
> [...]
>> --- broken/drivers/net/r8169.c 2007-11-07 12:32:29.000000000 -0500
>> +++ linux/drivers/net/r8169.c 2007-11-07 12:55:07.000000000 -0500
>> @@ -1325,6 +1325,7 @@
>> rtl8169sb_hw_phy_config(ioaddr);
>> break;
>> case RTL_GIGA_MAC_VER_11:
>> + break;
>> case RTL_GIGA_MAC_VER_12:
>> case RTL_GIGA_MAC_VER_17:
>> rtl8168b_hw_phy_config(ioaddr);
>
> I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
> too, namely XID = 0x38000000.
..
Tested and working here on VER_11. I don't have a VER_12, so I left that as-is.
If you want to fix that as well, just move the new "break;" down one line.
The rest of the broken commit works fine without the new call
to rtl8168b_hw_phy_config(ioaddr).
It's been weeks now, so please FIX it now.
Thanks.
next prev parent reply other threads:[~2007-11-07 22:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 16:07 r8169: NFG in 2.6.24-rc2 Mark Lord
2007-11-07 17:11 ` Mark Lord
2007-11-07 18:02 ` [PATCH] r8169 fix regression on ASUS motherboards Mark Lord
2007-11-07 22:04 ` Francois Romieu
2007-11-07 22:21 ` Mark Lord [this message]
2007-11-07 22:25 ` [PATCH] r8169 fix regression on ASUS motherboards (updated) Mark Lord
2007-11-07 22:48 ` Francois Romieu
2007-11-07 23:23 ` Mark Lord
2007-11-07 23:20 ` Mark Lord
2007-11-08 0:21 ` Francois Romieu
2007-11-08 8:49 ` Hans-Jürgen Koch
2007-11-08 14:16 ` [PATCH] r8169 fix regression on ASUS motherboards (updated again) Mark Lord
2007-11-08 21:05 ` Francois Romieu
2007-11-07 21:03 ` r8169: NFG in 2.6.24-rc2 cecco
2007-11-07 22:08 ` Francois Romieu
2007-11-08 7:52 ` Hans-Jürgen Koch
2007-11-08 8:44 ` Hans-Jürgen Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47323A69.5050206@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox