public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH] r8169 fix regression on ASUS motherboards (updated)
Date: Wed, 07 Nov 2007 17:25:47 -0500	[thread overview]
Message-ID: <47323B6B.9000909@rtr.ca> (raw)
In-Reply-To: <47323A69.5050206@rtr.ca>

Mark Lord wrote:
> Francois Romieu wrote:
>..
>> I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
>> too, namely XID = 0x38000000.
..

Here is the updated patch for both VER_11 and VER_12.
Let's get this in, as the driver has been broken for weeks now.

* * * *

Fix r8169 regression on ASUS motherboards.

Second attempt.  This one fixes both VER_11 and VER_12 MACs.

The r8169 ethernet driver worked fine in 2.6.23, but fails
in 2.6.24-rc* for the onboard ethernet of ASUS P5B series motherboards.
This patch fixes it again.

Signed-off-by: Mark Lord <mlord@pobox.com>

--- broken/drivers/net/r8169.c	2007-11-03 16:24:16.000000000 -0400
+++ linux/drivers/net/r8169.c	2007-11-07 17:22:59.000000000 -0500
@@ -1326,6 +1326,7 @@
 		break;
 	case RTL_GIGA_MAC_VER_11:
 	case RTL_GIGA_MAC_VER_12:
+		break;
 	case RTL_GIGA_MAC_VER_17:
 		rtl8168b_hw_phy_config(ioaddr);
 		break;

  reply	other threads:[~2007-11-07 22:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 16:07 r8169: NFG in 2.6.24-rc2 Mark Lord
2007-11-07 17:11 ` Mark Lord
2007-11-07 18:02 ` [PATCH] r8169 fix regression on ASUS motherboards Mark Lord
2007-11-07 22:04   ` Francois Romieu
2007-11-07 22:21     ` Mark Lord
2007-11-07 22:25       ` Mark Lord [this message]
2007-11-07 22:48         ` [PATCH] r8169 fix regression on ASUS motherboards (updated) Francois Romieu
2007-11-07 23:23           ` Mark Lord
2007-11-07 23:20         ` Mark Lord
2007-11-08  0:21           ` Francois Romieu
2007-11-08  8:49             ` Hans-Jürgen Koch
2007-11-08 14:16             ` [PATCH] r8169 fix regression on ASUS motherboards (updated again) Mark Lord
2007-11-08 21:05               ` Francois Romieu
2007-11-07 21:03 ` r8169: NFG in 2.6.24-rc2 cecco
2007-11-07 22:08   ` Francois Romieu
2007-11-08  7:52 ` Hans-Jürgen Koch
2007-11-08  8:44   ` Hans-Jürgen Koch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47323B6B.9000909@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox