Re: [PATCH] r8169 fix regression on ASUS motherboards

Francois Romieu
2007-11-07T22:05:40Z

Mark Lord <lkml@rtr.ca> :
> Fix r8169 regression on ASUS motherboards.
>
> The r8169 ethernet driver worked fine in 2.6.23, but fails
> in 2.6.24-rc* for the onboard ethernet of ASUS P5B series motherboards.
> This patch fixes it again.
[...]
> --- broken/drivers/net/r8169.c 2007-11-07 12:32:29.000000000 -0500
> +++ linux/drivers/net/r8169.c 2007-11-07 12:55:07.000000000 -0500
> @@ -1325,6 +1325,7 @@
> rtl8169sb_hw_phy_config(ioaddr);
> break;
> case RTL_GIGA_MAC_VER_11:
> + break;
> case RTL_GIGA_MAC_VER_12:
> case RTL_GIGA_MAC_VER_17:
> rtl8168b_hw_phy_config(ioaddr);

I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
too, namely XID = 0x38000000.

I would much prefer to revert the broken commit completely (which I am
currently isolating).

--
Ueimor