Re: [PATCH] r8169 fix regression on ASUS motherboards (updated)

Mark Lord
2007-11-07T23:23:52Z

Francois Romieu wrote:
> Mark Lord <lkml@rtr.ca> :
>> Mark Lord wrote:
>>> Francois Romieu wrote:
>>> ..
>>>> I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
>>>> too, namely XID = 0x38000000.
>> ..
>>
>> Here is the updated patch for both VER_11 and VER_12.
>> Let's get this in, as the driver has been broken for weeks now.
>
> I have not been waiting for you and I am not interested in your
> controversy.
>
> I'll find the offending commit and revert it. It is that simple.
..

I think the rest of the commit was fine -- there seems to be some
nice cleanups there to make it easier to maintain.

Just the new register writes (rtl8168b_hw_phy_config()) are mucking things up.
Prevent those from happening, and all is well.

Cheers