Re: [PATCH] r8169 fix regression on ASUS motherboards (updated)

Mark Lord
2007-11-07T23:20:44Z

Mark Lord wrote:
> Mark Lord wrote:
>> Francois Romieu wrote:
>> ..
>>> I am not convinced, the broken ones include some RTL_GIGA_MAC_VER_12
>>> too, namely XID = 0x38000000.
> ..
>
> Here is the updated patch for both VER_11 and VER_12.
> Let's get this in, as the driver has been broken for weeks now.
>
> * * * *
>
> Fix r8169 regression on ASUS motherboards.
>
> Second attempt. This one fixes both VER_11 and VER_12 MACs.
>
> The r8169 ethernet driver worked fine in 2.6.23, but fails
> in 2.6.24-rc* for the onboard ethernet of ASUS P5B series motherboards.
> This patch fixes it again.
>
> Signed-off-by: Mark Lord <mlord@pobox.com>
>
> --- broken/drivers/net/r8169.c 2007-11-03 16:24:16.000000000 -0400
> +++ linux/drivers/net/r8169.c 2007-11-07 17:22:59.000000000 -0500
> @@ -1326,6 +1326,7 @@
> break;
> case RTL_GIGA_MAC_VER_11:
> case RTL_GIGA_MAC_VER_12:
> + break;
> case RTL_GIGA_MAC_VER_17:
> rtl8168b_hw_phy_config(ioaddr);
> break;
..

I've now received a couple of private emails from people reporting
full success with this patch.

Cheers