From: Jeff Garzik <jeff@garzik.org>
To: peer chen <peerchen@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide <linux-ide@vger.kernel.org>,
akpm <akpm@linux-foundation.org>, Kuan Luo <kluo@nvidia.com>
Subject: Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv
Date: Fri, 09 Nov 2007 23:04:40 -0500 [thread overview]
Message-ID: <47352DD8.6040607@garzik.org> (raw)
In-Reply-To: <cfaab6210710211855q7a2de35co13d3017b2a07d4cc@mail.gmail.com>
peer chen wrote:
> Yes, link - http://lkml.org/lkml/2007/10/8/93 add the AHCI legacy
> support to sata_nv when IDE/RAID mode been set in SBIOS and Device IDs
> are not in ahci.c at this moment. To do so, when a new chipset come
> out and DIDs haven't been submited to LKML,user still can use ahci
> driver to handle it when setting AHCI mode in BIOS, using sata_nv when
> setting RAID/IDE in BIOS.
> For example, ahci driver in Fedora 7 doesn't include the DIDs of
> MCP78, so if you set the IDE/RAID mode in BIOS, os installation onto
> SATA drive will fail. But if Fedora 7 include this patch, installation
> will be successful.
The problem with this change is that sata_nv picks it up through the
default entry, and then later on, ahci picks it up as well.
Rather than the confusion of "which driver is the user running on this
hardware?" it is easier to take steps to ensure the user is always
running in AHCI mode.
Therefore, I think the best idea is to follow the same policy as
drivers/net/forcedeth.c (Ayaz @ NVIDIA) and Intel AHCI, and simply
provide the individual PCI IDs in advance of product release.
If you wish to avoid this, then take steps to make sure
drivers/ata/ahci.c has the appropriate wildcard entry in its
pci_device_id table.
Really, look at the sata_nv bug reports that keep popping up. We want
to move away from that driver long term, and always drive the SATA
interface in AHCI mode.
The proposed sata_nv patch does the opposite -- guarantees we must
support the continually problematic legacy IDE interface ad infinitum.
Such patches are OK for the test lab, but in this specific case users
/suffer/ when not running AHCI mode.
Jeff
next prev parent reply other threads:[~2007-11-10 4:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 5:23 [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv Peer Chen
2007-09-25 7:08 ` Jeff Garzik
2007-09-25 7:52 ` Peer Chen
2007-09-25 8:13 ` Jeff Garzik
2007-09-25 9:08 ` Peer Chen
2007-10-12 21:17 ` Jeff Garzik
2007-10-16 8:08 ` peer chen
2007-10-19 2:56 ` Jeff Garzik
2007-10-19 6:58 ` peer chen
2007-10-19 7:25 ` Jeff Garzik
2007-10-22 1:55 ` peer chen
2007-11-10 4:04 ` Jeff Garzik [this message]
2007-11-10 5:00 ` Jeff Garzik
2007-11-10 19:00 ` Robert Hancock
2007-12-11 12:04 ` [PATCH] sata_nv,adma: fix error when rmmod sata_nv Kuan Luo
2007-12-12 8:18 ` Tejun Heo
2007-12-13 3:10 ` Kuan Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47352DD8.6040607@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=kluo@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peerchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox