public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, davem@davemloft.net, apw@shadowen.org
Subject: Re: [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.
Date: Sat, 10 Nov 2007 11:24:58 +0100	[thread overview]
Message-ID: <473586FA.4080402@cosmosbay.com> (raw)
In-Reply-To: <20071110094149.GA25923@linux.vnet.ibm.com>

Kamalesh Babulal a écrit :
> Hi,
> 
> The 2.6.24-rc2-git1 kernel build fails, with following error
> 
>   CC      security/selinux/hooks.o
> In file included from include/net/tcp.h:35,
>                  from security/selinux/hooks.c:52:
> include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc':
> include/net/inet_hashtables.h:165: error: implicit declaration of function 'vmalloc'
> include/net/inet_hashtables.h:165: warning: assignment makes pointer from integer without a cast
> include/net/inet_hashtables.h: In function 'inet_ehash_locks_free':
> include/net/inet_hashtables.h:186: error: implicit declaration of function 'vfree'
> make[2]: *** [security/selinux/hooks.o] Error 1
> make[1]: *** [security/selinux] Error 2
> make: *** [security] Error 2
> 
> The commit 230140cffa7feae90ad50bf259db1fa07674f3a7 ([INET]: Remove per
> bucket rwlock in tcp/dccp ehash table.) caused this build
> failure.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> --
> diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h
> index 8461cda..469216d 100644
> --- a/include/net/inet_hashtables.h
> +++ b/include/net/inet_hashtables.h
> @@ -23,6 +23,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/types.h>
>  #include <linux/wait.h>
> +#include <linux/vmalloc.h>
>  
>  #include <net/inet_connection_sock.h>
>  #include <net/inet_sock.h>
> 

Yes, same patch was posted some hours ago, but Tony didnt acknowledged it.

http://marc.info/?l=linux-kernel&m=119465902731847&w=2

Thank you

  reply	other threads:[~2007-11-10 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10  9:41 [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks Kamalesh Babulal
2007-11-10 10:24 ` Eric Dumazet [this message]
2007-11-10 10:48   ` Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473586FA.4080402@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=davem@davemloft.net \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox