From: Paolo Bonzini <pbonzini@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>,
Like Xu <like.xu.linux@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Jing Liu <jing2.liu@intel.com>,
linux-kernel@vger.kernel.org, "Bae,
Chang Seok" <chang.seok.bae@intel.com>
Subject: Re: [PATCH] x86/cpufeatures: Move the definition of X86_FEATURE_AMX_* to the word 18
Date: Tue, 18 Jan 2022 18:15:29 +0100 [thread overview]
Message-ID: <47362220-30d5-c513-a2aa-61187ee91c41@redhat.com> (raw)
In-Reply-To: <8b274c5f-6b68-aed9-117d-f89249e57e18@intel.com>
On 1/18/22 18:11, Dave Hansen wrote:
> What tree is this against? I see BF16 and INT8 in some old versions of
> Chang's patches, but not current kernels. All I see right now in
> tip/master is:
>
>> #define X86_FEATURE_AMX_TILE (18*32+24) /* AMX tile ...
>
> It's still in the wrong spot, but the other two features aren't there.
It was added for the KVM side of AMX (commit 690a757d610e, "kvm: x86:
Add CPUID support for Intel AMX") and is in Linus's tree.
Paolo
>> We have defined the word 18 for Intel-defined CPU features from CPUID level> 0x00000007:0 (EDX). Let's move the definitions of X86_FEATURE_AMX_* to
> the> right entry to prevent misinterpretation. No functional change
> intended.
> Please, no "we's" in changelogs. Don't say, "let's move". Just say:
> "Move..."
>
> The subject could probably also be trimmed a bit. Perhaps:
>
> x86/cpu: Move AMX CPU feature defines to correct word location
>
>
next prev parent reply other threads:[~2022-01-18 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 6:23 [PATCH] x86/cpufeatures: Move the definition of X86_FEATURE_AMX_* to the word 18 Like Xu
2022-01-17 8:24 ` Paolo Bonzini
2022-01-18 17:11 ` Dave Hansen
2022-01-18 17:15 ` Paolo Bonzini [this message]
2022-01-19 3:41 ` Like Xu
2022-01-29 14:19 ` Borislav Petkov
2022-02-08 8:08 ` Like Xu
2022-02-08 8:51 ` Borislav Petkov
2022-02-08 9:06 ` Like Xu
2022-02-08 9:21 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47362220-30d5-c513-a2aa-61187ee91c41@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jing2.liu@intel.com \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox