From: Scott Wood <scottwood@freescale.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jochen Friedrich <jochen@scram.de>,
"linuxppc-embedded@ozlabs.org" <linuxppc-embedded@ozlabs.org>,
linux-kernel@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: Add EXPORT_SYMBOL for symbols required by fs_enet and cpm_uart
Date: Mon, 12 Nov 2007 10:49:53 -0600 [thread overview]
Message-ID: <47388431.3020609@freescale.com> (raw)
In-Reply-To: <20071111201503.GA18749@infradead.org>
Christoph Hellwig wrote:
> On Sun, Nov 11, 2007 at 06:01:37PM +0100, Jochen Friedrich wrote:
>> --- a/arch/powerpc/sysdev/commproc.c
>> +++ b/arch/powerpc/sysdev/commproc.c
>> @@ -51,6 +51,8 @@ static void m8xx_cpm_dpinit(void);
>> static uint host_buffer; /* One page of host buffer */
>> static uint host_end; /* end + 1 */
>> cpm8xx_t __iomem *cpmp; /* Pointer to comm processor space */
>> +EXPORT_SYMBOL(cpmp);
>
> Sorry, but this is a nightmare waiting to happen. Please define
> proper accessors instead.
We have proper accessors: in_be32, out_be16, etc.
Now, is the huge struct encompassing all of immr space a bad idea?
Sure. Are we working towards getting rid of it? Yes. Is that a reason
to keep modules from working in the meantime? No.
> (And get rid of the typedef while you're at it)
Again, changing all the users is a bit beyond the scope of this patch.
-Scott
next prev parent reply other threads:[~2007-11-12 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 17:01 [PATCH] powerpc: Add EXPORT_SYMBOL for symbols required by fs_enet and cpm_uart Jochen Friedrich
2007-11-11 20:15 ` Christoph Hellwig
2007-11-12 16:49 ` Scott Wood [this message]
2007-11-12 17:29 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47388431.3020609@freescale.com \
--to=scottwood@freescale.com \
--cc=hch@infradead.org \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox