From: Tejun Heo <teheo@suse.de>
To: miaox@cn.fujitsu.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysfs: fix off-by-one error in fill_read_buffer
Date: Tue, 13 Nov 2007 13:43:29 +0900 [thread overview]
Message-ID: <47392B71.5000009@suse.de> (raw)
In-Reply-To: <47391EFA.4000004@cn.fujitsu.com>
Miao Xie wrote:
> on 2007-11-12 22:08 Tejun Heo wrote:
>> It isn't strictly a bug. If the ->show() op fills full PAGE_SIZE and
>> returns PAGE_SIZE, the user will get full PAGE_SIZE bytes correctly, so
>> it will work. However, considering normal use cases, return value of
>> PAGE_SIZE very likely indicates an error condition, so considering it a
>> BUG condition is a good idea.
>>
>> Miao, can you please note that the code works fine with PAGE_SIZE return
>> but it's likely to indicate truncated result or overflow in normal use
>> cases as a comment on top of the BUG_ON()?
>>
>> Thanks.
>
> OK, I did it.
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Acked-by: Tejun Heo <htejun@gmail.com>
Greg, can you please push this one? Thanks.
--
tejun
prev parent reply other threads:[~2007-11-13 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 11:06 [PATCH] sysfs: fix off-by-one error in fill_read_buffer Miao Xie
2007-11-12 14:08 ` Tejun Heo
2007-11-13 3:50 ` Miao Xie
2007-11-13 4:43 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47392B71.5000009@suse.de \
--to=teheo@suse.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox