From: Srinivasa Ds <srinivasa@in.ibm.com>
To: Abhishek Sagar <sagar.abhishek@gmail.com>
Cc: linux-kernel@vger.kernel.org, prasanna@in.ibm.com,
davem@davemloft.net, anil.s.keshavamurthy@intel.com,
Jim Keniston <jkenisto@us.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Subject: Re: [PATCH][RFC] kprobes: Add user entry-handler in kretprobes
Date: Wed, 14 Nov 2007 15:53:58 +0530 [thread overview]
Message-ID: <473ACCBE.9010308@in.ibm.com> (raw)
In-Reply-To: <863e9df20711140049q3ad486ben7ace2edab0a2ca41@mail.gmail.com>
Abhishek Sagar wrote:
> the entry handler is called with the appropriate return instance. I
> haven't put any explicit "match" test here for ri. The reason is that
> the correct ri would be passed to both the entry and return handlers
> as trampoline_handler() explicitly matches them to the correct task.
> Note that all pending return instances of a function are chained in
> LIFO order. S the entry-handler which gets called last, should have
> its return handler called first (in case of multiple pending return
> instances).
>
No, eventhough return instances are chained in an order, order of execution of
return handler entirely depends on which process returns first(some process may
return from 2 line of the function and some process may return from last line
of the function). So entry_handler() which gets executed last doesn't guarantee
that its return handler will be executed first(because it took a lot time
to return).
So only thing to match the entry_handler() with its return_handler() is
return probe instance(ri)'s address, which user has to take care explicitly
(Hence I feel sol a) would be nice).
Thanks
Srinivasa DS
next prev parent reply other threads:[~2007-11-14 10:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47389BEB.1000901@gmail.com>
2007-11-12 18:39 ` [PATCH][RFC] kprobes: Add user entry-handler in kretprobes Abhishek Sagar
2007-11-13 10:47 ` Abhishek Sagar
2007-11-14 7:57 ` Srinivasa Ds
2007-11-14 8:49 ` Abhishek Sagar
2007-11-14 10:23 ` Srinivasa Ds [this message]
2007-11-14 13:30 ` Abhishek Sagar
2007-11-14 22:51 ` Jim Keniston
2007-11-15 13:16 ` Abhishek Sagar
2007-11-15 21:16 ` Jim Keniston
2007-11-16 17:50 ` Abhishek Sagar
2007-11-17 0:54 ` Jim Keniston
2007-11-17 18:15 ` Abhishek Sagar
2007-11-19 12:26 ` Abhishek Sagar
2007-11-21 5:55 ` Jim Keniston
2007-11-21 10:20 ` Abhishek Sagar
2007-11-27 0:54 ` Jim Keniston
2007-11-15 15:00 ` Abhishek Sagar
2007-11-16 0:07 ` Jim Keniston
2007-11-16 18:53 ` Abhishek Sagar
2007-11-16 23:09 ` Jim Keniston
2007-11-17 17:09 ` Abhishek Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473ACCBE.9010308@in.ibm.com \
--to=srinivasa@in.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=sagar.abhishek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox