From: Eric Dumazet <dada1@cosmosbay.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mingo@elte.hu, tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv2 4/4] first use of sys_indirect system call
Date: Fri, 16 Nov 2007 03:57:59 +0100 [thread overview]
Message-ID: <473D0737.1040504@cosmosbay.com> (raw)
In-Reply-To: <200711151822.lAFIMVnJ028596@devserv.devel.redhat.com>
Ulrich Drepper a écrit :
> This is a first user of sys_indirect. Several of the socket-related system
> calls which produce a file handle now can be passed an additional parameter
> to set the FD_CLOEXEC flag.
>
> - retval = sock_map_fd(sock);
> + retval = sock_map_fd_flags(sock, current->indirect_params.file_flags.flags);
Yes, we know now why you wanted sys_indirect so much :)
However, there should be a macro or something to ease reader mind...
#define INDPARAM(SUBSYSNAME,PARAMNAME) \
(current->indirect_params.##SUBSYSNAME.##PARAMNAME)
> + retval = sock_map_fd_flags(sock, INDPARAM(file_flags,flags));
next prev parent reply other threads:[~2007-11-16 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 18:22 [PATCHv2 4/4] first use of sys_indirect system call Ulrich Drepper
2007-11-16 2:57 ` Eric Dumazet [this message]
2007-11-16 18:08 ` dean gaudet
2007-11-16 18:19 ` Ulrich Drepper
2007-11-16 18:22 ` dean gaudet
2007-11-16 18:59 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473D0737.1040504@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@linux-foundation.org \
--cc=drepper@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox