Re: [PATCH v3 10/17] Remove some CFS specific code from the wakeup path of RT tasks

Steven Rostedt
2007-11-17T18:52:13Z

On Sat, 17 Nov 2007, Gregory Haskins wrote:

> >>> On Sat, Nov 17, 2007 at 1:21 AM, in message
> <20071117062404.672976284@goodmis.org>, Steven Rostedt <rostedt@goodmis.org>
> wrote:
>
> > + */
> > + if (idle_cpu(cpu) || cpu_rq(cpu)->nr_running > 1)
> > + return cpu;
> > +
> > + for_each_domain(cpu, sd) {
> > + if (sd->flags & SD_WAKE_IDLE) {
> > + cpus_and(tmp, sd->span, p->cpus_allowed);
> > + for_each_cpu_mask(i, tmp) {
> > + if (idle_cpu(i))
> > + return i;
> ^^^^^^^^^^^^^^^^
>
> Looks like some stuff that was added in 24 was inadvertently lost in the move when you merged the patches up from 23.1-rt11. The attached patch is updated to move the new logic as well.
>

Doh! Good catch. Will rework on Monday.

-- Steve