From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Greg KH <greg@kroah.com>
Cc: David <david@unsolicited.net>, Ingo Molnar <mingo@elte.hu>,
gregkh@suse.de, Javier Kohen <jkohen@users.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] Soft lockups since stable kernel upgrade to 2.6.23.8
Date: Sat, 17 Nov 2007 16:34:56 -0800 [thread overview]
Message-ID: <473F88B0.1030309@goop.org> (raw)
In-Reply-To: <20071117203705.GA21045@kroah.com>
Greg KH wrote:
> Great, thanks for tracking this down.
>
> Ingo, this corrisponds to changeset
> a115d5caca1a2905ba7a32b408a6042b20179aaa in mainline. Is that patch
> incorrect? Should this patch in the -stable tree be reverted?
>
Hm, I've never observed a problem with this in mainline.
Ah. The significant difference between 2.6.23 and -git is that the
former used sched_clock as the softlockup timebase, versus cpu_clock in
git. If sched_clock() is tsc-based, and the tsc isn't stable when using
cpufreq, then the softlockup with get confused and fire spuriously.
Ingo's fix to reporting exposed the fact that softlockup is terminally
broken in that kernel.
I think the best course for now is to revert it, since softlockup is
hardly a critical feature. The proper fixes would either be to backport
cpu_clock() to 2.6.23, or make it go back to using ticks.
J
next prev parent reply other threads:[~2007-11-18 0:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 18:21 Soft lockups since stable kernel upgrade to 2.6.23.8 Javier Kohen
2007-11-17 19:12 ` [stable] " Greg KH
2007-11-17 20:05 ` David
2007-11-17 20:37 ` Greg KH
2007-11-18 0:34 ` Jeremy Fitzhardinge [this message]
2007-11-19 23:22 ` Greg KH
2007-11-20 1:40 ` Jeremy Fitzhardinge
2007-11-20 6:05 ` Ingo Molnar
2007-11-20 17:05 ` Greg KH
2007-11-20 20:39 ` Ingo Molnar
2007-11-20 21:03 ` Greg KH
2007-11-20 21:49 ` Ingo Molnar
2007-11-20 22:06 ` Greg KH
2007-11-20 23:15 ` David Miller
2007-11-20 23:26 ` Ingo Molnar
2007-11-20 23:52 ` Greg KH
2007-11-18 0:55 ` Ingo Molnar
2007-11-20 0:30 ` Chuck Ebbert
2007-11-20 6:08 ` Ingo Molnar
2007-11-20 17:04 ` Greg KH
2007-11-17 19:40 ` David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473F88B0.1030309@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=david@unsolicited.net \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jkohen@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox