From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753618AbcFAMYc (ORCPT ); Wed, 1 Jun 2016 08:24:32 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:50851 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbcFAMYa (ORCPT ); Wed, 1 Jun 2016 08:24:30 -0400 From: Arnd Bergmann To: Shawn Lin Cc: Wenrui Li , Bharat Kumar Gogada , Bjorn Helgaas , Heiko Stuebner , Rob Herring , "devicetree@vger.kernel.org" , Doug Anderson , "linux-pci@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc Date: Wed, 01 Jun 2016 14:24:19 +0200 Message-ID: <4741248.3AsB27IYfk@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1463740105-7061-1-git-send-email-shawn.lin@rock-chips.com> <4816755.yFEaWXVu6I@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZKUFFQviOYsV9bB9lcgJhNwcJ475pTPHAaKjQYoQ79XZsuhVqkT 0LbYHr7cc9uImHTeU8+Zn4CufzphSJLFbbJj42RM1v8fhSGxfmYtmjvXsvZZqOEeJ5vx6q9 y7XHtx7iKOYhrRfPLhMbd4ZFHJZ2y5XoqgukGipht1sbueNxmU6QFbqA+1w85/uurKfhXfa yad9L91toOi0dLTXFoViw== X-UI-Out-Filterresults: notjunk:1;V01:K0:+Nrt8OCUiyA=:35UKj1+9IvkDpsUlcvWBL1 uTb8j6g47gCp1zMWBmAFfcdbpBvq4B0f4uiFENe867mpmGTDLPNPNvpUfUmDfsP/PcKb2teer wz79oeY/zBCQYvdbWDht3zqkGhtkeDjQMZjuSraSsKx+RvFpUZDTNCNds3It9eELgO7GclvGz g9+GLkiFSQcwH/yWKjtdH9FWl5sdVG6Gyq0raGGsxCfMC+/hKXqCw48PNAnyCFlOQIp5AAKuW D0lhU+SiTIjtmEJLQrnrHVqv9IuTfSHS7kpGSFCEu3DXePqWvZ/bm6LIJsHazKqLInisZ1yWJ ybqDoqNcFz4j8SLS2N7bfP6tvsz80LH5/OHOM6PlxlTJSsIsIjpGDgYwaegvT+siXkEBBO9/a l6vlUPZ+f6rQRmC8se/Y3T3aqz/deQLaGcPzLiAMNhyj38NS74wSLfEqdoIhiN93tZ+6HprCS ytm9qqDGNnBeyZj6hOlxzthozU17qw37p7BmTJ7SR5jyXyysTg6FunNNqMjilvkTt/mDh6puR pCuwZOek0rR5XJP7EFTapULSulqjOyhrByTqa02T7D5z7bHw3rehYwhyQtbpwzSmMJZ7qrFsZ L8K6UfL8ozTqJiz2LTu5UWoPnIC+cLTJ0w7c88ZnrrhvcHzCr91ncaWNdCzzKO4wTKJR0apkb kNkha3Wd+omQcidWvy7qN3Ac4Abt/TZAvdl5Schew3TwrBFgDL1I+ggVgX1nHG7fHtH2HMbQO PXdzfRrmarPGY1un Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 1, 2016 5:57:25 PM CEST Shawn Lin wrote: > yes, that is what we need and we believe other host bridges have > this requirements. With your patch applied, we only need to > implement our map0 callback here. Thanks for improving it. > > BTW, would you mind that we pack your patch into my patchset for > the next version if possible, or maybe you wanna upstream it > by yourself? I think the patch still needs a little improvement and discussion. I've just done a second version, and tried out converting two of the existing drivers to it, with good results. We might want to add another set of callbacks for the first indirect level, as that could help designware, mvebu and rcar at the minimum. We then end up with 'root' config, 'port type 1' config and 'device type 0' config, with the first two falling back on the third when unavailable. I'm sending out what I have now. Arnd