From: Ulrich Drepper <drepper@redhat.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mingo@elte.hu, tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv3 0/4] sys_indirect system call
Date: Mon, 19 Nov 2007 07:48:23 -0800 [thread overview]
Message-ID: <4741B047.9080601@redhat.com> (raw)
In-Reply-To: <20071119164329.5a580b84.dada1@cosmosbay.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Eric Dumazet wrote:
> So when you recompile your old program (as you post it and as I commented on),
> it will pass a >= 12 bytes data to kernel, with only first 4 bytes set to O_CLOEXEC.
>
> Other bytes will contain junk
If you don't initialize the entire structure and you use it all, of
course you get undefined behavior. That's nothing new. The program I
attached is not an example, it's a test for the functionality in this patch.
Like with every kernel interface, you have to use it correctly. The
good news is that user programs should never use this syscall directly
(just like don't for existing ones).
I see no problem at all here.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFHQbBH2ijCOnn/RHQRAkc3AKCxVTWQ3BiQnCBwdbAsT122QWWaiwCggKXN
Z5Sz9/NFojMHZXXTzIMoxX4=
=slte
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-11-19 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 5:31 [PATCHv3 0/4] sys_indirect system call Ulrich Drepper
2007-11-18 7:44 ` H. Peter Anvin
2007-11-18 9:36 ` Ulrich Drepper
2007-11-18 19:37 ` H. Peter Anvin
2007-11-20 3:28 ` Ulrich Drepper
2007-11-20 4:27 ` H. Peter Anvin
2007-11-19 13:52 ` Eric Dumazet
2007-11-19 15:12 ` Ulrich Drepper
2007-11-19 15:43 ` Eric Dumazet
2007-11-19 15:48 ` Ulrich Drepper [this message]
2007-11-19 16:14 ` Eric Dumazet
2007-11-19 19:08 ` Ingo Molnar
2007-11-20 14:11 ` dean gaudet
2007-11-20 16:16 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4741B047.9080601@redhat.com \
--to=drepper@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox