From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Greg KH <gregkh@suse.de>
Cc: Greg KH <greg@kroah.com>, David <david@unsolicited.net>,
Ingo Molnar <mingo@elte.hu>,
Javier Kohen <jkohen@users.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] Soft lockups since stable kernel upgrade to 2.6.23.8
Date: Mon, 19 Nov 2007 17:40:54 -0800 [thread overview]
Message-ID: <47423B26.1090607@goop.org> (raw)
In-Reply-To: <20071119232252.GC3528@suse.de>
Greg KH wrote:
> Can you try applying the patch below to see if that solves the problem
> for you?
>
I don't think this patch will help; it only has cosmetic changes in
addition to the original message printing fix. I think it also needs
change a3b13c23f186ecb57204580cc1f2dbe9c284953a:
diff -r 79f0ea1e0e70 -r 06f060ab58aa kernel/softlockup.c
--- a/kernel/softlockup.c Tue Oct 09 21:00:40 2007 +0000
+++ b/kernel/softlockup.c Wed Oct 17 08:42:46 2007 -0700
@@ -40,14 +40,16 @@ static struct notifier_block panic_block
* resolution, and we don't need to waste time with a big divide when
* 2^30ns == 1.074s.
*/
-static unsigned long get_timestamp(void)
+static unsigned long get_timestamp(int this_cpu)
{
- return sched_clock() >> 30; /* 2^30 ~= 10^9 */
+ return cpu_clock(this_cpu) >> 30; /* 2^30 ~= 10^9 */
}
void touch_softlockup_watchdog(void)
{
- __raw_get_cpu_var(touch_timestamp) = get_timestamp();
+ int this_cpu = raw_smp_processor_id();
+
+ __raw_get_cpu_var(touch_timestamp) = get_timestamp(this_cpu);
}
EXPORT_SYMBOL(touch_softlockup_watchdog);
@@ -91,7 +93,7 @@ void softlockup_tick(void)
return;
}
- now = get_timestamp();
+ now = get_timestamp(this_cpu);
/* Wake up the high-prio watchdog task every second: */
if (now > (touch_timestamp + 1))
J
next prev parent reply other threads:[~2007-11-20 1:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 18:21 Soft lockups since stable kernel upgrade to 2.6.23.8 Javier Kohen
2007-11-17 19:12 ` [stable] " Greg KH
2007-11-17 20:05 ` David
2007-11-17 20:37 ` Greg KH
2007-11-18 0:34 ` Jeremy Fitzhardinge
2007-11-19 23:22 ` Greg KH
2007-11-20 1:40 ` Jeremy Fitzhardinge [this message]
2007-11-20 6:05 ` Ingo Molnar
2007-11-20 17:05 ` Greg KH
2007-11-20 20:39 ` Ingo Molnar
2007-11-20 21:03 ` Greg KH
2007-11-20 21:49 ` Ingo Molnar
2007-11-20 22:06 ` Greg KH
2007-11-20 23:15 ` David Miller
2007-11-20 23:26 ` Ingo Molnar
2007-11-20 23:52 ` Greg KH
2007-11-18 0:55 ` Ingo Molnar
2007-11-20 0:30 ` Chuck Ebbert
2007-11-20 6:08 ` Ingo Molnar
2007-11-20 17:04 ` Greg KH
2007-11-17 19:40 ` David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47423B26.1090607@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=david@unsolicited.net \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jkohen@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox