From: Ulrich Drepper <drepper@redhat.com>
To: Zach Brown <zach.brown@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mingo@elte.hu, tglx@linutronix.de, torvalds@linux-foundation.org
Subject: Re: [PATCHv4 4/6] Allow setting FD_CLOEXEC flag for new sockets
Date: Tue, 20 Nov 2007 10:07:35 -0800 [thread overview]
Message-ID: <47432267.4040202@redhat.com> (raw)
In-Reply-To: <474320C4.2040600@oracle.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Zach Brown wrote:
> Have you given thought to having to perform compat translation on this?
> Today it's only copied directly from the user pointer into the union
> in the task_struct.
Since there is no legacy interface to worry about all members added to
the structure can and should be neutral of the word size. We've done
this with some syscalls already (like pread64) where we always use the
wide form in the parameter list. It's just more simple here since it
does not have to split into two 32-bit registers.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFHQyJn2ijCOnn/RHQRAmWeAJ0Q6qBDtZDvsZYlfBnPFL6n11Z+lwCghiVp
NklFHsSnVyQYMD5rinDFQPo=
=Yo5E
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-11-20 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 6:53 [PATCHv4 4/6] Allow setting FD_CLOEXEC flag for new sockets Ulrich Drepper
2007-11-20 18:00 ` Zach Brown
2007-11-20 18:07 ` Ulrich Drepper [this message]
2007-11-20 18:15 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47432267.4040202@redhat.com \
--to=drepper@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox