From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843D036728F for ; Wed, 1 Jul 2026 16:38:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923919; cv=none; b=hxWz/qCrd/Hpf+m9Sxooy7Y1Tv81pQuFEA3QmcbkkBlUL4pzNOF1SULfEM+q00yYS77Gu8sU63ZQC7IiY7KTpe/vO0hiW9TSetY0Qd3ui84qQeJ92aDPg+ZewznZzLmZ0RwubVYyjgCu4vpq3kH1TJSnVwI7lRbsNnibC9YzT4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782923919; c=relaxed/simple; bh=Zr450RWnPkR02FXE57wKaTpGBJLmZ9mEGcGZznebyO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rDw8rAiwzzgwuXUeCcMF2G5xLkdTrvac83SVr7z8DdQSdd//f4yWciLbHOTMfK5A8FygnPRh1XH4iNpMNdxNQQSf0bgAIr4BsOkfT93E3pgII9+nwZeGlTIvhRRHjluGC0/LcRAlf6ySl+Rg+XPxbOBrDCmXIC5LUCvKef9jSAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com; spf=pass smtp.mailfrom=codeweavers.com; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b=OLqUstFy; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=epS09+gj; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="OLqUstFy"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="epS09+gj" Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id A30801400183; Wed, 1 Jul 2026 12:38:36 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 01 Jul 2026 12:38:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeweavers.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1782923916; x=1783010316; bh=noJQ6PnTmJpTYfKs7/1LMRZB54PIWEIE pH/0dXwcuD0=; b=OLqUstFynYQN1we928uWogGlRv+CajNZW7v1iBP/R58p66ze hfR60c7YL31aAjYPzz9ithegwl3Mokv10FSZjVU96T+4qz39eVL60r9kG8IAo6wF GMDynVtYze5cfAHo++YpZTfSOU3X9Z0hJn9LsW8TIeW3Iu1mmOfhCFKmpJ9x/zAT zqkoSvhDONWqllfKnTqCotYKobX6CzPW5AcZ3+NYjIKEl2MYuHftaxin53gS8M6C jsw7p+JZWRdM4vlZQFkdUkhCyk8ff6+TWyZyWabVQBLWhLd58P27l/oKajPY110c yOTTT+rycGKFfDuFkLTjEpnV/XJ608vUsYiWgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1782923916; x= 1783010316; bh=noJQ6PnTmJpTYfKs7/1LMRZB54PIWEIEpH/0dXwcuD0=; b=e pS09+gjbmj6fk6TH18U3D+Gf1I8Pl1SCdLsPF0DTzRyzIC9o+GCOVBHFtHj5UlZW 7zL0eH94jP5ELQcBrbPRoPLgyTx3SJW+e2UVXqm7Wflza1Wjq676eneuZuvnxbVm v7p5ydiK5rBZRgVgFOBwZnXHWb7VvYR8ejbRnzcp64kVNY35OKnhGSHz5qj89u4K s7ePSykzMBxfrC7L1a0VE0mZeCrIjc3CFFh6W+vAZYm6G8BwHGm0162ce8rfTi7o iG2Hzm+0S0OEiOlVhKLCRuEY6ZQTIdunq1Fp97qJ61PUTUjEcq44iUngHEYzJ2v5 8G9ZAejo7cC4epikxR+ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEZSMFhPa5h8iaJ//3ur6cz5BAVlL6fmZJriyGgOB074eHmjtUSS9OHCRmyKRhlJZ fKoSYFSRAtoTZ8jzEjXMuskPD+q7zGsnTulJBue0ohYCIkTN0aguVfDf3e+tesDhi+/dBf 1IbO+poGPN2AVPE3Kr2BYBtwZqRLamz1bInl94+alrv8Ql5zI3stlI2U/M2jmc4rthIvWa P+XJJl95kwcCECM6M4dSeCRXbp033uY8MyM6wAuxKc4mzT3Vzi232Pr0lO0UvRFNtEIBDM yjOkhgpAIfpyxqpktky4Wk6c5eBAW+YpERz4uXiuQwjqjwh/M1A0j7DnA6BZhVmBG6AGSK lcC7wyZmAVqH95TywclFw1sKs0/p301InycPWqxci793QIKg3MVtM4n9QUeHHUdWPicIcw KUuTThD5oF2QJNHqvFZE/1Syk6Ac6L9fD5bAoJ0f48ZBAfgxbzZPPrRKjYp8wDMq6V5euL vQwabLToKIUfalbG80L1zwgC6s+jKLd44hpl8oHEwFKYJmtKb+INX7AYTgBkAgJeKiqnz6 Uwaf4HRLl+OpOd2Od7bPkzwkbuc57SSo2UnCVkrFsnxoc91bKEaSf6a7cDcQcchBj+cF2f +maxRjDS2BTf9zwhpTIjjQrn8JXnInsBpCndQ0Y7xoxsR2t52w37UuZqHpeg X-ME-Proxy: Feedback-ID: i01ae4b70:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jul 2026 12:38:36 -0400 (EDT) From: Elizabeth Figura To: =?UTF-8?B?SXbDoW4=?= Ezequiel Rodriguez Cc: wine-devel@winehq.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] selftests: ntsync: add wait argument validation tests Date: Wed, 01 Jul 2026 11:38:35 -0500 Message-ID: <4743910.LvFx2qVVIh@camazotz> In-Reply-To: <20260628024239.152852-4-ivanrwcm25@gmail.com> References: <20260628024239.152852-1-ivanrwcm25@gmail.com> <20260628024239.152852-4-ivanrwcm25@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Saturday, 27 June 2026 21:42:38 CDT Iv=C3=A1n Ezequiel Rodriguez wrote: > Add coverage for documented EINVAL cases: zero owner on wait any/all, > non-zero pad, and objects from a different /dev/ntsync instance. >=20 > Signed-off-by: Iv=C3=A1n Ezequiel Rodriguez > --- > .../testing/selftests/drivers/ntsync/ntsync.c | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) >=20 > diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/test= ing/selftests/drivers/ntsync/ntsync.c > index 12b4b81edf7f..c9fe4d5987ec 100644 > --- a/tools/testing/selftests/drivers/ntsync/ntsync.c > +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c > @@ -1340,4 +1340,48 @@ TEST(stress_wait) > close(stress_device); > } > =20 > +TEST(wait_args_validation) > +{ > + struct ntsync_sem_args sem_args =3D { .count =3D 1, .max =3D 1 }; > + struct ntsync_wait_args wait_args =3D {0}; > + struct timespec timeout; > + int fd, fd2, sem, ret; > + __u32 index; > + > + fd =3D open("/dev/ntsync", O_CLOEXEC | O_RDONLY); > + ASSERT_GE(fd, 0); > + > + fd2 =3D open("/dev/ntsync", O_CLOEXEC | O_RDONLY); > + ASSERT_GE(fd2, 0); > + > + sem =3D ioctl(fd, NTSYNC_IOC_CREATE_SEM, &sem_args); > + EXPECT_GE(sem, 0); > + > + ret =3D wait_any(fd, 1, &sem, 0, &index); > + EXPECT_EQ(-1, ret); > + EXPECT_EQ(EINVAL, errno); > + > + ret =3D wait_all(fd, 1, &sem, 0, &index); > + EXPECT_EQ(-1, ret); > + EXPECT_EQ(EINVAL, errno); > + > + clock_gettime(CLOCK_MONOTONIC, &timeout); > + wait_args.timeout =3D timeout.tv_sec * 1000000000ULL + timeout.tv_nsec; > + wait_args.count =3D 0; > + wait_args.objs =3D 0; > + wait_args.owner =3D 123; > + wait_args.pad =3D 1; > + ret =3D ioctl(fd, NTSYNC_IOC_WAIT_ANY, &wait_args); > + EXPECT_EQ(-1, ret); > + EXPECT_EQ(EINVAL, errno); > + > + ret =3D wait_any(fd2, 1, &sem, 123, &index); > + EXPECT_EQ(-1, ret); > + EXPECT_EQ(EINVAL, errno); > + > + close(sem); > + close(fd2); > + close(fd); > +} > + > TEST_HARNESS_MAIN >=20 Reviewed-by: Elizabeth Figura