From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839AbcBBOJX (ORCPT ); Tue, 2 Feb 2016 09:09:23 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:60947 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754383AbcBBOJV (ORCPT ); Tue, 2 Feb 2016 09:09:21 -0500 From: Arnd Bergmann To: Brijesh Singh Cc: Tejun Heo , linux-kernel@vger.kernel.org, hdegoede@redhat.com, linux-ide@vger.kernel.org, Graeme Gregory Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver Date: Tue, 02 Feb 2016 15:08:59 +0100 Message-ID: <4743985.XZ7D12RurV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56AFD91F.4030008@amd.com> References: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> <5709817.yQT8N3CaLj@wuerfel> <56AFD91F.4030008@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:DjwATBsl18pD687uUkqSsZN1b+31s20AfapBlHt9KdYRaBo/ARN RuEcwtUEK2nphGJzvgwkqwnDsSNfTNWkoi9qMo5j7UsLotOiVCTl+QvJ0rrv0kprJzqEkYt NvVd5OyjumO8PKt2JgoewClYDHlWGo08VHUMZA7rM0loCTn9zqWPBO2cbwmHlYOLbUNp7BE m489dvv+z2AKPVwgdicIg== X-UI-Out-Filterresults: notjunk:1;V01:K0:CavxH68jVd8=:To4eu/7IPWWP8AkUmfAcE0 f9Y97y79s36x98SCpIxs0IfvTl2zyVnRMAS8V7+dS3H2f0woXHuiIAwkqF4RNWLgf5Kp4bpHu IbpbSoI7VDbi0Qtqq8F8iuvABQMQHCrKGbjWqigLbGmkZW46q0PapEPmqU68DlBXgPehFVFf1 +NRAQRIP6S40efDpUDBciWtk5nBFtx0nxUmdu9OK6IX2eoIThpBo0L3OKhTUfxWe/mv/oJuD1 rVBb66CgVFZ/PtkMn3Sl03nNQ66fW51upLyiZvgZJ60mgaG7vZn3XlGEkQ8FBTRbH/3L/o+Hl vfp1ixRaTDYwGHBGnfVB4LHB037KBOcZUSn28tN2ZugTHK9MPjYZvAAzXm7NWlUVF+PPo7VvN ueh341U5r79Z2CH82istpEA7K9gkPChixGZ6dXE6CgON23e23Cb33gS121HTbFBy5KWGwR2MO EW303UK4IWamG4rUdRq8QQMtHykJN14rMXjROUTObk+TEqUO0NosBCzJcDXI1lRV2QpW6s8nQ WTXRkS99jUybm1wtLXXBRkZbDWuUz9icb6VQJRBtVoI9KFeJNoiklFCO9jqiIBWcOr6H8bl3f CRcZWCzjjE3nzC03e+Lw7fDfJES/zhIujjjVcZaU4p7gQNXVrivKLwisGxsKYUn+Gt8p8e0Cx kBZu82DcmjiZEbICft+G7OGaMRYBoq4hmugq3Y1KCArQnHQN/CMFFZhD/6zNRHotYJOetuZZv E4TP116LDozo52ho Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 01 February 2016 16:15:59 Brijesh Singh wrote: > > > > This is where we really need the ACPI maintainers to explain the > > general policy for dealing with firmware updates. > > > > I would assume that adding the feature in a later firmware version > > is a compatible change, and the feature is non-essential (the > > device will work fine with the generic SATA driver, except > > the LEDs don't blink), so it's not a big deal, it's just what > > you get for having the firmware shipped before the driver is > > reviewed (don't do that). > > > > Agreed, the driver should have been reviewed earlier. And now changes in firmware will also require > them changing other OSes drivers. Can you explain that? I would expect the addition of some AML methods to be a compatible change. Arnd