* [PATCH] Isolate the UTS namespace's domainname and hostname back
@ 2007-11-21 11:06 Pavel Emelyanov
2007-11-21 11:14 ` Cedric Le Goater
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-11-21 11:06 UTC (permalink / raw)
To: Andrew Morton
Cc: Cedric Le Goater, Linux Kernel Mailing List, Linux Containers
The commit
commit 7d69a1f4a72b18876c99c697692b78339d491568
Author: Cedric Le Goater <clg@fr.ibm.com>
Date: Sun Jul 15 23:40:58 2007 -0700
remove CONFIG_UTS_NS and CONFIG_IPC_NS
accidentally removed the code, that prevented the uts->hostname
and uts->domainname values from being overwritten from another
namespace. In other words, setting hostname/domainname via sysfs
(echo xxx > /proc/sys/kernel/(host|domain)name) cased the new
value to be set in init UTS namespace only.
Return the isolation back.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/kernel/utsname_sysctl.c b/kernel/utsname_sysctl.c
index c76c064..fe3a56c 100644
--- a/kernel/utsname_sysctl.c
+++ b/kernel/utsname_sysctl.c
@@ -18,6 +18,10 @@
static void *get_uts(ctl_table *table, int write)
{
char *which = table->data;
+ struct uts_namespace *uts_ns;
+
+ uts_ns = current->nsproxy->uts_ns;
+ which = (which - (char *)&init_uts_ns) + (char *)uts_ns;
if (!write)
down_read(&uts_sem);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Isolate the UTS namespace's domainname and hostname back
2007-11-21 11:06 [PATCH] Isolate the UTS namespace's domainname and hostname back Pavel Emelyanov
@ 2007-11-21 11:14 ` Cedric Le Goater
0 siblings, 0 replies; 2+ messages in thread
From: Cedric Le Goater @ 2007-11-21 11:14 UTC (permalink / raw)
To: Pavel Emelyanov
Cc: Andrew Morton, Linux Kernel Mailing List, Linux Containers
Pavel Emelyanov wrote:
> The commit
>
> commit 7d69a1f4a72b18876c99c697692b78339d491568
> Author: Cedric Le Goater <clg@fr.ibm.com>
> Date: Sun Jul 15 23:40:58 2007 -0700
>
> remove CONFIG_UTS_NS and CONFIG_IPC_NS
>
> accidentally removed the code, that prevented the uts->hostname
> and uts->domainname values from being overwritten from another
> namespace. In other words, setting hostname/domainname via sysfs
> (echo xxx > /proc/sys/kernel/(host|domain)name) cased the new
> value to be set in init UTS namespace only.
>
> Return the isolation back.
yep. sorry about that. I was going to send the same patch in a
minute.
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Cedric Le Goater <clg@fr.ibm.com>
Thanks,
C.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-21 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-21 11:06 [PATCH] Isolate the UTS namespace's domainname and hostname back Pavel Emelyanov
2007-11-21 11:14 ` Cedric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox