From: Robert Hancock <hancockr@shaw.ca>
To: vincent.fortier1@ec.gc.ca
Cc: ide <linux-ide@vger.kernel.org>, Jeff Garzik <jeff@garzik.org>,
Tejun Heo <htejun@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2)
Date: Wed, 21 Nov 2007 08:23:38 -0600 [thread overview]
Message-ID: <47443F6A.3050205@shaw.ca> (raw)
In-Reply-To: <1195648784.11490.0.camel@kayak.wul.qc.ec.gc.ca>
Vincent Fortier wrote:
> Le mardi 20 novembre 2007 à 18:56 -0600, Robert Hancock a écrit :
>> This fixes some problems with ATAPI devices on nForce4 controllers in ADMA
>> mode on systems with memory located above 4GB. We need to delay setting the
>> 64-bit DMA mask until the PRD table and padding buffer are allocated so that
>> they don't get allocated above 4GB and break legacy mode (which is needed for
>> ATAPI devices). Also, explicitly set a 32-bit DMA mask before allocating the
>> legacy buffers since setting the DMA mask affects both ports and we need to
>> ensure the second port's buffers are allocated properly (fixes a problem
>> with the previous version of this patch).
>>
>> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
>>
>
> Would this be worth sending to stable team for 2.6.22 & 2.6.23 ?
Likely (after it gets merged), those versions would have the same bug..
next prev parent reply other threads:[~2007-11-21 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 0:56 [PATCH] sata_nv: fix ADMA ATAPI issues with memory over 4GB (v2) Robert Hancock
[not found] ` <1195648784.11490.0.camel@kayak.wul.qc.ec.gc.ca>
2007-11-21 14:23 ` Robert Hancock [this message]
2007-11-22 6:35 ` Tejun Heo
2007-11-23 1:01 ` Robert Hancock
2007-11-23 1:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47443F6A.3050205@shaw.ca \
--to=hancockr@shaw.ca \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.fortier1@ec.gc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox