From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: James.Bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@linaro.org, linux-samsung-soc@vger.kernel.org,
santoshsy@gmail.com, arnd@linaro.org,
girish.shivananjappa@linaro.org, saugata.das@linaro.org,
vishak.g@samsung.com, venkat@linaro.org, k.rajesh@samsung.com,
dsaxena@linaro.org, ilho215.lee@samsung.com, nala.la@samsung.com,
sreekumar.c@samsung.com
Subject: Re: [PATCH V2 2/4] [SCSI] drivers/scsi/ufs: Add PCI glue driver
Date: Fri, 13 Jul 2012 18:01:58 +0200 [thread overview]
Message-ID: <4746865.F6XkGPQgWn@eto> (raw)
In-Reply-To: <1342189698-20393-1-git-send-email-vinholikatti@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
Vinayak Holikatti wrote:
> +static int __devinit
> +ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> +{
> + struct ufs_hba *hba;
> + void __iomem *mmio_base;
> + int err;
> +
> + err = pci_enable_device(pdev);
> + if (err) {
> + dev_err(&pdev->dev, "pci_enable_device failed\n");
> + goto out_error;
> + }
My question as basically every time at this point: why not use devres, i.e.
pcim_enable_device()? This would make the cleanup and error handling much
easier. See Documentation/driver-model/devres.txt.
> +
> + pci_set_master(pdev);
> +
> +
Duplicate newline.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-07-13 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 14:28 [PATCH V2 2/4] [SCSI] drivers/scsi/ufs: Add PCI glue driver Vinayak Holikatti
2012-07-13 14:28 ` [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd Vinayak Holikatti
2012-07-16 13:49 ` Namjae Jeon
2012-07-17 6:09 ` vinayak holikatti
2012-07-19 12:16 ` Namjae Jeon
2012-07-13 16:01 ` Rolf Eike Beer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4746865.F6XkGPQgWn@eto \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@linaro.org \
--cc=dsaxena@linaro.org \
--cc=girish.shivananjappa@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=k.rajesh@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nala.la@samsung.com \
--cc=patches@linaro.org \
--cc=santoshsy@gmail.com \
--cc=saugata.das@linaro.org \
--cc=sreekumar.c@samsung.com \
--cc=venkat@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox