From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] x86/geode: fix incorrect placement of __initdata tag
Date: Tue, 01 Oct 2013 12:37:47 +0200 [thread overview]
Message-ID: <4748759.pZGOv2NGcn@amdc1032> (raw)
In-Reply-To: <20131001065950.GC19718@gmail.com>
Hi,
On Tuesday, October 01, 2013 08:59:50 AM Ingo Molnar wrote:
>
> * Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
>
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > arch/x86/platform/geode/alix.c | 2 +-
> > arch/x86/platform/geode/geos.c | 2 +-
> > arch/x86/platform/geode/net5501.c | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Does this fix have any runtime effects, i.e. should we queue this up as an
> urgent fix for v3.12, or does tip:x86/platform with a v3.13 merge suffice?
It has runtime effects as the data now goes into .init.data which was not
a case previously. However it is not an urgent fix so I think that queuing
it for v3.13 is a better option. Thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2013-10-01 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 13:21 [PATCH] x86/geode: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-10-01 6:59 ` Ingo Molnar
2013-10-01 10:37 ` Bartlomiej Zolnierkiewicz [this message]
2013-10-01 13:00 ` [tip:x86/platform] x86/geode: Fix " tip-bot for Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4748759.pZGOv2NGcn@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=hpa@zytor.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox