Re: 2.6.24-rc3-mm1 make headers_check fails

Adrian Bunk
2007-11-24T14:34:27Z

On Wed, Nov 21, 2007 at 10:58:21AM +0100, Sam Ravnborg wrote:
> On Wed, Nov 21, 2007 at 10:44:40AM +0200, Avi Kivity wrote:
> > Kamalesh Babulal wrote:
> > >Andrew Morton wrote:
> > >
> > >>On Wed, 21 Nov 2007 13:54:50 +0530 Kamalesh Babulal
> > >><kamalesh@linux.vnet.ibm.com> wrote:
> > >>
> > >>
> > >>>The make headers_check fails,
> > >>>
> > >>> CHECK include/linux/usb/gadgetfs.h
> > >>> CHECK include/linux/usb/ch9.h
> > >>> CHECK include/linux/usb/cdc.h
> > >>> CHECK include/linux/usb/audio.h
> > >>> CHECK include/linux/kvm.h
> > >>>/root/kernels/linux-2.6.24-rc3/usr/include/linux/kvm.h requires
> > >>>asm/kvm.h, which does not exist in exported headers
> > >>>
> > >>hm, works for me, on i386 and x86_64. What's different over there?
> > >>
> > >Hi Andrew,
> > >
> > >It fails on the powerpc box, with allyesconfig option.
> > >
> > >
> >
> > How do we fix this? Export linux/kvm.h only on x86? Seems ugly.
>
> Is kvm x86 specific? Then move the .h file to asm-x86.
> Otherwise no good idea...

What about adding a whitelist in hdrcheck.sh?

For all practical purposes in userspace the compile error due to the
non-existing asm header should be fine, so there's no reason to change
the code in such cases.

> Sam

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed