Re: 2.6.24-rc3-mm1

Andrew Morton
2007-11-21T06:16:34Z

On Wed, 21 Nov 2007 14:03:34 +0800 "Dave Young" <hidave.darkstar@gmail.com> wrote:

> On Nov 21, 2007 2:00 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Wed, 21 Nov 2007 13:51:47 +0800 "Dave Young" <hidave.darkstar@gmail.com> wrote:
> >
> > > Hi, andrew
> > >
> > > modpost failed for me:
> > > MODPOST 360 modules
> > > ERROR: "empty_zero_page" [drivers/kvm/kvm.ko] undefined!
> > > make[1]: *** [__modpost] Error 1
> > > make: *** [modules] Error 2
> > >
> >
> > You're a victim of the hasty unexporting fad. Which architecture?
> > x86_64 I guess?
> >
> Hi,
> ia32 instead.
>

oic. Like this, I guess.

--- a/arch/x86/kernel/i386_ksyms_32.c~git-x86-i386-export-empty_zero_page
+++ a/arch/x86/kernel/i386_ksyms_32.c
@@ -2,6 +2,7 @@
#include <asm/semaphore.h>
#include <asm/checksum.h>
#include <asm/desc.h>
+#include <asm/pgtable.h>

EXPORT_SYMBOL(__down_failed);
EXPORT_SYMBOL(__down_failed_interruptible);
@@ -22,3 +23,4 @@ EXPORT_SYMBOL(__put_user_8);
EXPORT_SYMBOL(strstr);

EXPORT_SYMBOL(csum_partial);
+EXPORT_SYMBOL(empty_zero_page);
_