From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/3] x86: clean up bitops-related warnings
Date: Tue, 27 Nov 2007 15:32:51 -0800 [thread overview]
Message-ID: <474CA923.9080207@goop.org> (raw)
In-Reply-To: <200711280017.33344.ak@suse.de>
Andi Kleen wrote:
> On Wednesday 28 November 2007 00:01:26 Jeremy Fitzhardinge wrote:
>
>> Add casts to appropriate places to silence spurious bitops warnings.
>>
>
> Looks a bit ugly. Perhaps it would be better to define standard wrappers
>
> clear_bit_unaligned/any/bettername() etc. ?
Well, most of the casts are already in wrapper functions. The
setup_64.c ones are ugly, but the following patch cleans them up.
J
next prev parent reply other threads:[~2007-11-27 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071127230124.271668615@goop.org>
2007-11-27 23:01 ` [PATCH 1/3] x86: partial unification of asm-x86/bitops.h Jeremy Fitzhardinge
2007-11-28 0:32 ` Ingo Molnar
2007-11-27 23:01 ` [PATCH 2/3] x86: clean up bitops-related warnings Jeremy Fitzhardinge
2007-11-27 23:17 ` Andi Kleen
2007-11-27 23:32 ` Jeremy Fitzhardinge [this message]
2007-11-27 23:01 ` [PATCH 3/3] x86: add set/clear_cpu_cap operations Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474CA923.9080207@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox