Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

[Mark Lord <lkml@rtr.ca>]

Greg KH wrote:
> On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote:
>> (resending .. somebody trimmed the CC: list earlier)
>>
>> Greg KH wrote:
>>>>>> Mark Lord wrote:
>>>>>>> ..
>>>>>>>
>>>>>>> While doing insert/remove (quickly) tests on USB,
>>>>>>> I managed to trigger an Oops on 2.6.23.8 on a call
>>>>>>> to strlen() in make_class_name().
>> ...
>>
>>> I'll hold off on adding this patch for now.
>> ..
>>
>> Why?
>>
>> Bugs that result in Oops in core code (class.c) can bite
>> just about any subsystem that does hotplug, and should get
>> prompt attention.  Or so one might think.
> 
> And they have, the 2.6.24 kernel should have the correct fix for this
> problem, right?  The fact that you oopsed out in this function enabled
> people to find and fix the problem already.  Adding a BUG_ON() does the
> same exact thing :)
..

Well, actually BUG_ON() allows the system to continue running
while still not masking the issue.  But close enough.


> So again, the problem is in the higher up scsi layer, and that is where
> the problem should already be fixed.
..

Ahhh.. so you figure the Oops should also have been fixed
as part of the 2.6.24 SCSI fixes ?  That's what I was missing here.

Thanks.