public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List 
	<netfilter-devel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	davem@davemloft.net, stable@kernel.org
Subject: Re: [PATCH] Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK
Date: Thu, 29 Nov 2007 23:28:20 +0100	[thread overview]
Message-ID: <474F3D04.1020000@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711292314110.3089@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK
>
>
> When xt_CONNMARK is used outside the mangle table and the user specified
> "--restore-mark", the connmark_tg_check() function will (correctly)
> error out, but (incorrectly) forgets to release the L3 conntrack module.
> Same for xt_CONNSECMARK.
> Fix is to move the call to acquire the L3 module after the basic 
> constraint checks.
>   

Applied, thanks Jan.


      reply	other threads:[~2007-11-29 22:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 22:18 [PATCH] Fix forgotten module release in xt_CONNMARK and xt_CONNSECMARK Jan Engelhardt
2007-11-29 22:28 ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474F3D04.1020000@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox