public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <lkml@rtr.ca>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux Kernel <linux-acpi@vger.kernel.org>,
	len.brown@intel.com, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] 2.6.24: restore missing sysfs max_cstate attr
Date: Fri, 30 Nov 2007 14:06:19 -0500	[thread overview]
Message-ID: <47505F2B.2090109@rtr.ca> (raw)

Len, is there any good reason why max_cstate was made invisible in 2.6.24,
breaking my userspace scripts that access it?

Here's a patch to fix the regression from 2.6.23:

Restore visibility of /sys/module/processor/parameters/max_cstate 
for compatibility with kernels prior to 2.6.24.

I have scripts here that rely upon it.

Signed-off-by: Mark Lord <mlord@pobox.com>
---

Patch is against 2.6.24-rc3-git5.

--- linux/drivers/acpi/processor_idle.c.orig	2007-11-30 13:35:20.000000000 -0500
+++ linux/drivers/acpi/processor_idle.c	2007-11-30 13:35:31.000000000 -0500
@@ -76,7 +76,7 @@
 #define PM_TIMER_TICKS_TO_US(p)		(((p) * 1000)/(PM_TIMER_FREQUENCY/1000))
 
 static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER;
-module_param(max_cstate, uint, 0000);
+module_param(max_cstate, uint, 0644);
 static unsigned int nocst __read_mostly;
 module_param(nocst, uint, 0000);
 

                 reply	other threads:[~2007-11-30 19:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47505F2B.2090109@rtr.ca \
    --to=lkml@rtr.ca \
    --cc=akpm@linux-foundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox