From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754007AbbJPKBW (ORCPT ); Fri, 16 Oct 2015 06:01:22 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:62554 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752550AbbJPKBH (ORCPT ); Fri, 16 Oct 2015 06:01:07 -0400 From: Arnd Bergmann To: huangdaode Cc: davem@davemloft.net, joe@perches.com, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com, linux-kernel@vger.kernel.org, lipeng321@huawei.com Subject: [PATCH] net: hix5hd2_gmac: avoid integer overload warning Date: Fri, 16 Oct 2015 12:00:51 +0200 Message-ID: <4752736.dePgPCNd9q@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com> References: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rXZeW2u6A7BtszCb7oYp3pP/lMKP3wNb83jn63TPWWUgQqFErPZ RrYbAz+jFJutQusl+vaLRcdRdqvHYwiKhxA4L98zoImELu/u4d+Wto4X8HicG3o87qUrFNs DHxMSOkJmvi0f19QCysCmKe7y5EkpFdOt53zS1LwBGfjkrB0uN9mFqnBfTRsaQRsSRlFiGz ZwWvWOe2DV+ZBSRhnR0Wg== X-UI-Out-Filterresults: notjunk:1;V01:K0:IJT2pS869RA=:VxoWSHkqHCCZN1skHRgr8i xZs3HWkiQxKj05Z4XfnPQtn7ZT8fX94HygCb++sh3bYJL96rJb8d6068lQuELlCEq3MAUxvSE JHJsBvNanQXVRiVSFa7AxcOLhsn4FglTb2do4CCqjgpZwxIJjRz3JEF2Iyf4oG3pEHhsUWMjl DV1LJTmdFQCCwBORMnOq1Yzro+Br5awbCM2tSGQES4AhP/S18ITJx7KRP3PhCbsNWJWynLU1Q hmsW3b3GWqd4tSvBBE6jdYcin7G4fSn2apis/uWXY+RuZoB88ebajGGarU4a7ADU0VmqA1ndB OCgb74MTxNjyRecAb60yP21OfTckY7BVnE2db/Zg97MtWPKN63H9ByADi5lApf9vMwJL/U2aM NlmNZmH/CnmYOLsoYu9wem+9RurPpqK82Uo4F2s6x58QkpePXU4iX18IM8THDpu99toQM6Hrg 6SNhC/5e2eZrCuvHDk5D70wsYlLmHep5b32CTWKuPwqQbrDauSTsssiKNRA5ZbxRJvyGVbhpo YRVWsx3nTirWf9M95LelvfKDZ75uZbi9Ba0eQ3MfvVi0T0uypxalIf/1bLZ5IS5Nn4VWDQ2XK VUsrML2yCZ2lgzpWBabeeMIReWf5QMxgdlBI+dzfOw0fIrRLU/4HEr8KjiuOQ9fIHV/JcQ2NA LZupuFhqdgpojF0cfB8ITm0/rSG/yFkTNrrcqiLd8ELGCOGk03oCh5va3dVUARjq8IGBO2D4t hA1JJMiM7ZKMZ5pB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that has bits set that do not fit into a 32-bit variable on 64-bit architectures, which causes a harmless gcc warning: drivers/net/ethernet/hisilicon/hix5hd2_gmac.c: In function 'hix5hd2_port_disable': drivers/net/ethernet/hisilicon/hix5hd2_gmac.c:374:2: warning: large integer implicitly truncated to unsigned type [-Woverflow] writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); This adds a cast to (u32) to tell gcc that the code is indeed fine. Signed-off-by: Arnd Bergmann diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c index a5e077eac99a..e51892d518ff 100644 --- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c +++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c @@ -371,7 +371,7 @@ static void hix5hd2_port_enable(struct hix5hd2_priv *priv) static void hix5hd2_port_disable(struct hix5hd2_priv *priv) { - writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); + writel_relaxed(~(u32)(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); writel_relaxed(0, priv->base + DESC_WR_RD_ENA); }