* [PATCH] Documentation/BUG-HUNTING whitespace cleanup @ 2007-12-03 13:33 Clemens Koller 2007-12-03 16:31 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Clemens Koller @ 2007-12-03 13:33 UTC (permalink / raw) To: LKML List [-- Attachment #1: Type: text/plain, Size: 351 bytes --] Just a little whitespace cleanup patch for Documentation/BUG-HUNTING. Signed-off-by: Clemens Koller <clemens.koller@anagramm.de> -- Clemens Koller __________________________________ R&D Imaging Devices Anagramm GmbH Rupert-Mayer-Straße 45/1 Linhof Werksgelände D-81379 München Tel.089-741518-50 Fax 089-741518-19 http://www.anagramm-technology.com [-- Attachment #2: BUG-HUNTING-whitespace-cleanup.patch --] [-- Type: text/plain, Size: 3269 bytes --] diff --git a/Documentation/BUG-HUNTING b/Documentation/BUG-HUNTING index 35f5bd2..a41cb24 100644 --- a/Documentation/BUG-HUNTING +++ b/Documentation/BUG-HUNTING @@ -53,7 +53,7 @@ Finding it the old way [Sat Mar 2 10:32:33 PST 1996 KERNEL_BUG-HOWTO lm@sgi.com (Larry McVoy)] -This is how to track down a bug if you know nothing about kernel hacking. +This is how to track down a bug if you know nothing about kernel hacking. It's a brute force approach but it works pretty well. You need: @@ -66,12 +66,12 @@ You will then do: . Rebuild a revision that you believe works, install, and verify that. . Do a binary search over the kernels to figure out which one - introduced the bug. I.e., suppose 1.3.28 didn't have the bug, but + introduced the bug. I.e., suppose 1.3.28 didn't have the bug, but you know that 1.3.69 does. Pick a kernel in the middle and build that, like 1.3.50. Build & test; if it works, pick the mid point between .50 and .69, else the mid point between .28 and .50. . You'll narrow it down to the kernel that introduced the bug. You - can probably do better than this but it gets tricky. + can probably do better than this but it gets tricky. . Narrow it down to a subdirectory @@ -81,27 +81,27 @@ You will then do: directories: Copy the non-working directory next to the working directory - as "dir.63". + as "dir.63". One directory at time, try moving the working directory to - "dir.62" and mv dir.63 dir"time, try + "dir.62" and mv dir.63 dir"time, try mv dir dir.62 mv dir.63 dir find dir -name '*.[oa]' -print | xargs rm -f And then rebuild and retest. Assuming that all related - changes were contained in the sub directory, this should - isolate the change to a directory. + changes were contained in the sub directory, this should + isolate the change to a directory. Problems: changes in header files may have occurred; I've - found in my case that they were self explanatory - you may + found in my case that they were self explanatory - you may or may not want to give up when that happens. . Narrow it down to a file - You can apply the same technique to each file in the directory, - hoping that the changes in that file are self contained. - + hoping that the changes in that file are self contained. + . Narrow it down to a routine - You can take the old file and the new file and manually create @@ -130,7 +130,6 @@ You will then do: that makes the difference. Finally, you take all the info that you have, kernel revisions, bug -description, the extent to which you have narrowed it down, and pass that off to whomever you believe is the maintainer of that section. A post to linux.dev.kernel isn't such a bad idea if you've done some work to narrow it down. ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/BUG-HUNTING whitespace cleanup 2007-12-03 13:33 [PATCH] Documentation/BUG-HUNTING whitespace cleanup Clemens Koller @ 2007-12-03 16:31 ` Randy Dunlap 2007-12-03 16:47 ` [PATCH] Documentation/BUG-HUNTING whitespace cleanup, take 2 Clemens Koller 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2007-12-03 16:31 UTC (permalink / raw) To: Clemens Koller; +Cc: LKML List On Mon, 03 Dec 2007 14:33:29 +0100 Clemens Koller wrote: > Just a little whitespace cleanup patch for Documentation/BUG-HUNTING. > > Signed-off-by: Clemens Koller <clemens.koller@anagramm.de> Mostly looks OK, except for the last chunk: why delete that line? missing a + line? @@ -130,7 +130,6 @@ You will then do: that makes the difference. Finally, you take all the info that you have, kernel revisions, bug -description, the extent to which you have narrowed it down, and pass that off to whomever you believe is the maintainer of that section. A post to linux.dev.kernel isn't such a bad idea if you've done some work to narrow it down. --- ~Randy Features and documentation: http://lwn.net/Articles/260136/ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/BUG-HUNTING whitespace cleanup, take 2 2007-12-03 16:31 ` Randy Dunlap @ 2007-12-03 16:47 ` Clemens Koller 2007-12-03 16:50 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Clemens Koller @ 2007-12-03 16:47 UTC (permalink / raw) To: Randy Dunlap; +Cc: LKML List [-- Attachment #1: Type: text/plain, Size: 1022 bytes --] Randy Dunlap schrieb: > On Mon, 03 Dec 2007 14:33:29 +0100 Clemens Koller wrote: > >> Just a little whitespace cleanup patch for Documentation/BUG-HUNTING. >> >> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de> > > > Mostly looks OK, except for the last chunk: why delete that line? > missing a + line? > > > @@ -130,7 +130,6 @@ You will then do: > that makes the difference. > > Finally, you take all the info that you have, kernel revisions, bug > -description, the extent to which you have narrowed it down, and pass > that off to whomever you believe is the maintainer of that section. > A post to linux.dev.kernel isn't such a bad idea if you've done some > work to narrow it down. Hmm... that was not intended, updated patch attached. Thank you, -- Clemens Koller __________________________________ R&D Imaging Devices Anagramm GmbH Rupert-Mayer-Straße 45/1 Linhof Werksgelände D-81379 München Tel.089-741518-50 Fax 089-741518-19 http://www.anagramm-technology.com [-- Attachment #2: BUG-HUNTING-whitespace-cleanup-2.patch --] [-- Type: text/plain, Size: 3469 bytes --] Just a little whitespace cleanup patch for Documentation/BUG-HUNTING Signed-off-by: Clemens Koller <clemens.koller@anagramm.de> diff --git a/Documentation/BUG-HUNTING b/Documentation/BUG-HUNTING index 35f5bd2..6c81675 100644 --- a/Documentation/BUG-HUNTING +++ b/Documentation/BUG-HUNTING @@ -53,7 +53,7 @@ Finding it the old way [Sat Mar 2 10:32:33 PST 1996 KERNEL_BUG-HOWTO lm@sgi.com (Larry McVoy)] -This is how to track down a bug if you know nothing about kernel hacking. +This is how to track down a bug if you know nothing about kernel hacking. It's a brute force approach but it works pretty well. You need: @@ -66,12 +66,12 @@ You will then do: . Rebuild a revision that you believe works, install, and verify that. . Do a binary search over the kernels to figure out which one - introduced the bug. I.e., suppose 1.3.28 didn't have the bug, but + introduced the bug. I.e., suppose 1.3.28 didn't have the bug, but you know that 1.3.69 does. Pick a kernel in the middle and build that, like 1.3.50. Build & test; if it works, pick the mid point between .50 and .69, else the mid point between .28 and .50. . You'll narrow it down to the kernel that introduced the bug. You - can probably do better than this but it gets tricky. + can probably do better than this but it gets tricky. . Narrow it down to a subdirectory @@ -81,27 +81,27 @@ You will then do: directories: Copy the non-working directory next to the working directory - as "dir.63". + as "dir.63". One directory at time, try moving the working directory to - "dir.62" and mv dir.63 dir"time, try + "dir.62" and mv dir.63 dir"time, try mv dir dir.62 mv dir.63 dir find dir -name '*.[oa]' -print | xargs rm -f And then rebuild and retest. Assuming that all related - changes were contained in the sub directory, this should - isolate the change to a directory. + changes were contained in the sub directory, this should + isolate the change to a directory. Problems: changes in header files may have occurred; I've - found in my case that they were self explanatory - you may + found in my case that they were self explanatory - you may or may not want to give up when that happens. . Narrow it down to a file - You can apply the same technique to each file in the directory, - hoping that the changes in that file are self contained. - + hoping that the changes in that file are self contained. + . Narrow it down to a routine - You can take the old file and the new file and manually create @@ -130,7 +130,7 @@ You will then do: that makes the difference. Finally, you take all the info that you have, kernel revisions, bug -description, the extent to which you have narrowed it down, and pass +description, the extent to which you have narrowed it down, and pass that off to whomever you believe is the maintainer of that section. A post to linux.dev.kernel isn't such a bad idea if you've done some work to narrow it down. ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation/BUG-HUNTING whitespace cleanup, take 2 2007-12-03 16:47 ` [PATCH] Documentation/BUG-HUNTING whitespace cleanup, take 2 Clemens Koller @ 2007-12-03 16:50 ` Randy Dunlap 0 siblings, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2007-12-03 16:50 UTC (permalink / raw) To: Clemens Koller; +Cc: LKML List Clemens Koller wrote: > Randy Dunlap schrieb: > > On Mon, 03 Dec 2007 14:33:29 +0100 Clemens Koller wrote: > > > >> Just a little whitespace cleanup patch for Documentation/BUG-HUNTING. > >> > >> Signed-off-by: Clemens Koller <clemens.koller@anagramm.de> > > > > > > Mostly looks OK, except for the last chunk: why delete that line? > > missing a + line? > > > > > > @@ -130,7 +130,6 @@ You will then do: > > that makes the difference. > > > > Finally, you take all the info that you have, kernel revisions, bug > > -description, the extent to which you have narrowed it down, and pass > > that off to whomever you believe is the maintainer of that section. > > A post to linux.dev.kernel isn't such a bad idea if you've done some > > work to narrow it down. > > Hmm... that was not intended, updated patch attached. > > Thank you, > > > ------------------------------------------------------------------------ > > Just a little whitespace cleanup patch for Documentation/BUG-HUNTING > > Signed-off-by: Clemens Koller <clemens.koller@anagramm.de> Acked-by: Randy Dunlap <randy.dunlap@oracle.com> Thanks. -- ~Randy Features and documentation: http://lwn.net/Articles/260136/ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-12-03 16:52 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-12-03 13:33 [PATCH] Documentation/BUG-HUNTING whitespace cleanup Clemens Koller 2007-12-03 16:31 ` Randy Dunlap 2007-12-03 16:47 ` [PATCH] Documentation/BUG-HUNTING whitespace cleanup, take 2 Clemens Koller 2007-12-03 16:50 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox