From: Giacomo Catenazzi <cate@cateee.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: proc/bus.usb regression in : [NETNS]: Fix /proc/net breakage
Date: Thu, 06 Dec 2007 09:21:53 +0100 [thread overview]
Message-ID: <4757B121.6000308@cateee.net> (raw)
In-Reply-To: <20071205040236.ff102b9e.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Mon, 3 Dec 2007 19:00:25 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
>
>> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2b1e300a9dfc3196ccddf6f1d74b91b7af55e416
>> Commit: 2b1e300a9dfc3196ccddf6f1d74b91b7af55e416
>> Parent: e03ba84adb62fbc6049325a5bc00ef6932fa5e39
>> Author: Eric W. Biederman <ebiederm@xmission.com>
>> AuthorDate: Sun Dec 2 00:33:17 2007 +1100
>> Committer: Herbert Xu <herbert@gondor.apana.org.au>
>> CommitDate: Sun Dec 2 00:33:17 2007 +1100
>>
>> [NETNS]: Fix /proc/net breakage
>>
>> Well I clearly goofed when I added the initial network namespace support
>> for /proc/net. Currently things work but there are odd details visible to
>> user space, even when we have a single network namespace.
>>
>> Since we do not cache proc_dir_entry dentries at the moment we can just
>> modify ->lookup to return a different directory inode depending on the
>> network namespace of the process looking at /proc/net, replacing the
>> current technique of using a magic and fragile follow_link method.
>>
>> To accomplish that this patch:
>> - introduces a shadow_proc method to allow different dentries to
>> be returned from proc_lookup.
>> - Removes the old /proc/net follow_link magic
>> - Fixes a weakness in our not caching of proc generic dentries.
>>
>> As shadow_proc uses a task struct to decided which dentry to return we can
>> go back later and fix the proc generic caching without modifying any code
>> that uses the shadow_proc method.
>
> This patch caused the binfmt_misc regression reported in
> http://bugzilla.kernel.org/show_bug.cgi?id=9504
This patch also doesn't allow to mount /proc/bus/usb
ciao
cate
next prev parent reply other threads:[~2007-12-06 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200712031900.lB3J0PR9025742@hera.kernel.org>
2007-12-05 12:02 ` [NETNS]: Fix /proc/net breakage Andrew Morton
2007-12-06 8:21 ` Giacomo Catenazzi [this message]
2007-12-06 8:31 ` proc/bus.usb regression in : " Andrew Morton
2007-12-06 18:01 ` Giacomo Catenazzi
2007-12-06 8:36 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4757B121.6000308@cateee.net \
--to=cate@cateee.net \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox