From: Li Zefan <lizf@cn.fujitsu.com>
To: paulus@samba.org
Cc: LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head
Date: Thu, 06 Dec 2007 17:33:14 +0800 [thread overview]
Message-ID: <4757C1DA.6060603@cn.fujitsu.com> (raw)
The casting is safe only when the list_head member is the
first member of the structure.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
arch/ppc/syslib/ocp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c
index 3f5be2c..d42d408 100644
--- a/arch/ppc/syslib/ocp.c
+++ b/arch/ppc/syslib/ocp.c
@@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int function, int index)
down_write(&ocp_devices_sem);
dev = __ocp_find_device(vendor, function, index);
- list_del((struct list_head *)dev);
+ list_del(&dev->link);
up_write(&ocp_devices_sem);
DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... done.\n", vendor, function, index));
--
1.5.3.rc7
next reply other threads:[~2007-12-06 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 9:33 Li Zefan [this message]
2007-12-07 4:07 ` [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head Nick Piggin
2007-12-07 5:05 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4757C1DA.6060603@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox